Re: [PATCH 05/35] i2c: use dev_get_platdata()
Now it's convincing, thanks! signature.asc Description: Digital signature
Re: [PATCH 05/35] i2c: use dev_get_platdata()
Now it's convincing, thanks! signature.asc Description: Digital signature
Re: [PATCH 05/35] i2c: use dev_get_platdata()
On Friday, August 16, 2013 3:03 AM, Wolfram Sang wrote: > On Tue, Jul 30, 2013 at 04:59:33PM +0900, Jingoo Han wrote: > > Use the wrapper function for retrieving the platform data instead of > > accessing dev->platform_data directly. > > > > Signed-off-by: Jingoo Han > > Not convincing. I couldn't find a cover letter explaining the motivation > and if this should go via the seperate trees or via one cleanup pull > request. (and if there is one, the i2c list should be on cc) Also, all CC'ed Mark Brown (author of dev_get_platdata function) 1. Motivation This is a cosmetic change by in order to enhance readability and make the code simpler. If you want, I will modify the commit message as below: "Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change in order to enhance readability and make the code simpler." 2. via the separate trees It should go via the separate trees. > 35 patches seem to be seperate mails and not threaded, so I can't easily > check other opinions. Will skip for now unless somebody points out a > strong reason. 3. Other opinions Until now, there is no objection. Also, 21 patches of all 35 patches have been applied by each maintainer. Mark Brown, Sorry for CC'ing you. If I am wrong, please let me know kindly. :) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 05/35] i2c: use dev_get_platdata()
On Friday, August 16, 2013 3:03 AM, Wolfram Sang wrote: On Tue, Jul 30, 2013 at 04:59:33PM +0900, Jingoo Han wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Signed-off-by: Jingoo Han jg1@samsung.com Not convincing. I couldn't find a cover letter explaining the motivation and if this should go via the seperate trees or via one cleanup pull request. (and if there is one, the i2c list should be on cc) Also, all CC'ed Mark Brown (author of dev_get_platdata function) 1. Motivation This is a cosmetic change by in order to enhance readability and make the code simpler. If you want, I will modify the commit message as below: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. This is a cosmetic change in order to enhance readability and make the code simpler. 2. via the separate trees It should go via the separate trees. 35 patches seem to be seperate mails and not threaded, so I can't easily check other opinions. Will skip for now unless somebody points out a strong reason. 3. Other opinions Until now, there is no objection. Also, 21 patches of all 35 patches have been applied by each maintainer. Mark Brown, Sorry for CC'ing you. If I am wrong, please let me know kindly. :) Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 05/35] i2c: use dev_get_platdata()
On Tue, Jul 30, 2013 at 04:59:33PM +0900, Jingoo Han wrote: > Use the wrapper function for retrieving the platform data instead of > accessing dev->platform_data directly. > > Signed-off-by: Jingoo Han Not convincing. I couldn't find a cover letter explaining the motivation and if this should go via the seperate trees or via one cleanup pull request. (and if there is one, the i2c list should be on cc) Also, all 35 patches seem to be seperate mails and not threaded, so I can't easily check other opinions. Will skip for now unless somebody points out a strong reason. signature.asc Description: Digital signature
Re: [PATCH 05/35] i2c: use dev_get_platdata()
On Tue, Jul 30, 2013 at 04:59:33PM +0900, Jingoo Han wrote: Use the wrapper function for retrieving the platform data instead of accessing dev-platform_data directly. Signed-off-by: Jingoo Han jg1@samsung.com Not convincing. I couldn't find a cover letter explaining the motivation and if this should go via the seperate trees or via one cleanup pull request. (and if there is one, the i2c list should be on cc) Also, all 35 patches seem to be seperate mails and not threaded, so I can't easily check other opinions. Will skip for now unless somebody points out a strong reason. signature.asc Description: Digital signature
