Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Paolo Bonzini
On 12/04/2018 19:57, Sean Christopherson wrote: > On Thu, Apr 12, 2018 at 04:38:39PM +0200, Paolo Bonzini wrote: >> On 21/02/2018 18:47, KarimAllah Ahmed wrote: >>> + >>> + if (kvm_vcpu_map(vcpu, >>> gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) >>> +

Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Paolo Bonzini
On 12/04/2018 19:57, Sean Christopherson wrote: > On Thu, Apr 12, 2018 at 04:38:39PM +0200, Paolo Bonzini wrote: >> On 21/02/2018 18:47, KarimAllah Ahmed wrote: >>> + >>> + if (kvm_vcpu_map(vcpu, >>> gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) >>> +

Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Sean Christopherson
On Thu, Apr 12, 2018 at 04:38:39PM +0200, Paolo Bonzini wrote: > On 21/02/2018 18:47, KarimAllah Ahmed wrote: > > + > > + if (kvm_vcpu_map(vcpu, > > gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) > > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, > > gfn_to_gpa(map->pfn));

Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Sean Christopherson
On Thu, Apr 12, 2018 at 04:38:39PM +0200, Paolo Bonzini wrote: > On 21/02/2018 18:47, KarimAllah Ahmed wrote: > > + > > + if (kvm_vcpu_map(vcpu, > > gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) > > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, > > gfn_to_gpa(map->pfn));

Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Paolo Bonzini
On 21/02/2018 18:47, KarimAllah Ahmed wrote: > + > + if (kvm_vcpu_map(vcpu, > gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, > gfn_to_gpa(map->pfn)); This should in principle be pfn_to_hpa. However, pfn_to_hpa is

Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page

2018-04-12 Thread Paolo Bonzini
On 21/02/2018 18:47, KarimAllah Ahmed wrote: > + > + if (kvm_vcpu_map(vcpu, > gpa_to_gfn(vmcs12->virtual_apic_page_addr), map)) > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, > gfn_to_gpa(map->pfn)); This should in principle be pfn_to_hpa. However, pfn_to_hpa is