Re: [PATCH 06/12] KVM: x86: Move TSC scaling logic out of call-back adjust_tsc_offset()
On Mon, Sep 28, 2015 at 10:14:19PM +0200, Paolo Bonzini wrote: > > > On 28/09/2015 07:38, Haozhong Zhang wrote: > > + > > +static inline void adjust_tsc_offset_guest(struct kvm_vcpu *vcpu, > > + s64 adjustment) > > +{ > > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, false); > > +} > > + > > +static inline void adjust_tsc_offset_host(struct kvm_vcpu *vcpu, s64 > > adjustment) > > +{ > > + if (vcpu->arch.tsc_scaling_ratio != kvm_default_tsc_scaling_ratio) > > + WARN_ON(adjustment < 0); > > + adjustment = kvm_scale_tsc(vcpu, (u64) adjustment); > > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, true); > > +} > > You can remove the final argument to the callback (and possibly change > the callback's name to adjust_tsc_offset_guest), because it is now unused. > > Paolo Thanks! will do it. - Haozhong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/12] KVM: x86: Move TSC scaling logic out of call-back adjust_tsc_offset()
On 28/09/2015 07:38, Haozhong Zhang wrote: > + > +static inline void adjust_tsc_offset_guest(struct kvm_vcpu *vcpu, > +s64 adjustment) > +{ > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, false); > +} > + > +static inline void adjust_tsc_offset_host(struct kvm_vcpu *vcpu, s64 > adjustment) > +{ > + if (vcpu->arch.tsc_scaling_ratio != kvm_default_tsc_scaling_ratio) > + WARN_ON(adjustment < 0); > + adjustment = kvm_scale_tsc(vcpu, (u64) adjustment); > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, true); > +} You can remove the final argument to the callback (and possibly change the callback's name to adjust_tsc_offset_guest), because it is now unused. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/12] KVM: x86: Move TSC scaling logic out of call-back adjust_tsc_offset()
On 28/09/2015 07:38, Haozhong Zhang wrote: > + > +static inline void adjust_tsc_offset_guest(struct kvm_vcpu *vcpu, > +s64 adjustment) > +{ > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, false); > +} > + > +static inline void adjust_tsc_offset_host(struct kvm_vcpu *vcpu, s64 > adjustment) > +{ > + if (vcpu->arch.tsc_scaling_ratio != kvm_default_tsc_scaling_ratio) > + WARN_ON(adjustment < 0); > + adjustment = kvm_scale_tsc(vcpu, (u64) adjustment); > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, true); > +} You can remove the final argument to the callback (and possibly change the callback's name to adjust_tsc_offset_guest), because it is now unused. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/12] KVM: x86: Move TSC scaling logic out of call-back adjust_tsc_offset()
On Mon, Sep 28, 2015 at 10:14:19PM +0200, Paolo Bonzini wrote: > > > On 28/09/2015 07:38, Haozhong Zhang wrote: > > + > > +static inline void adjust_tsc_offset_guest(struct kvm_vcpu *vcpu, > > + s64 adjustment) > > +{ > > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, false); > > +} > > + > > +static inline void adjust_tsc_offset_host(struct kvm_vcpu *vcpu, s64 > > adjustment) > > +{ > > + if (vcpu->arch.tsc_scaling_ratio != kvm_default_tsc_scaling_ratio) > > + WARN_ON(adjustment < 0); > > + adjustment = kvm_scale_tsc(vcpu, (u64) adjustment); > > + kvm_x86_ops->adjust_tsc_offset(vcpu, adjustment, true); > > +} > > You can remove the final argument to the callback (and possibly change > the callback's name to adjust_tsc_offset_guest), because it is now unused. > > Paolo Thanks! will do it. - Haozhong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/