Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample
On Wed, Jul 25, 2012 at 06:36:28PM +0200, Frederic Weisbecker wrote: > On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote: > > Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger > > the dump of the user level stack on sample. The size of the > > dump is specified by sample_stack_user value. > > > > Being able to dump parts of the user stack, starting from the > > stack pointer, will be useful to make a post mortem dwarf CFI > > based stack unwinding. > > > > Signed-off-by: Jiri Olsa > > Signed-off-by: Frederic Weisbecker please use: Signed-off-by: Jiri Olsa Original-patch-by: Frederic Weisbecker > > If you keep the SOB of the author then you need to preserve its > authorship (git am --author= / git commit --amend --author=). > Unless you changed the patch significantly enough that you > simply credit with something like "Original-patch-by" and you become the > author. This is left to personal appreciation, I won't mind > in any case. > > But there is no middle ground :) > You also need to keep the SOB chain in order. The above SOB chain > suggests I'm carrying a patch from you. > > Just saying that so that you make the maintainers job easier ;) ok, I misunderstood this one when we discussed this, sorry The userspace part have some bad ones as well.. I talked to Arnaldo how to deal with them :) thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample
On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote: > Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger > the dump of the user level stack on sample. The size of the > dump is specified by sample_stack_user value. > > Being able to dump parts of the user stack, starting from the > stack pointer, will be useful to make a post mortem dwarf CFI > based stack unwinding. > > Signed-off-by: Jiri Olsa > Signed-off-by: Frederic Weisbecker If you keep the SOB of the author then you need to preserve its authorship (git am --author= / git commit --amend --author=). Unless you changed the patch significantly enough that you simply credit with something like "Original-patch-by" and you become the author. This is left to personal appreciation, I won't mind in any case. But there is no middle ground :) You also need to keep the SOB chain in order. The above SOB chain suggests I'm carrying a patch from you. Just saying that so that you make the maintainers job easier ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample
On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote: Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger the dump of the user level stack on sample. The size of the dump is specified by sample_stack_user value. Being able to dump parts of the user stack, starting from the stack pointer, will be useful to make a post mortem dwarf CFI based stack unwinding. Signed-off-by: Jiri Olsa jo...@redhat.com Signed-off-by: Frederic Weisbecker fweis...@gmail.com If you keep the SOB of the author then you need to preserve its authorship (git am --author= / git commit --amend --author=). Unless you changed the patch significantly enough that you simply credit with something like Original-patch-by and you become the author. This is left to personal appreciation, I won't mind in any case. But there is no middle ground :) You also need to keep the SOB chain in order. The above SOB chain suggests I'm carrying a patch from you. Just saying that so that you make the maintainers job easier ;) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample
On Wed, Jul 25, 2012 at 06:36:28PM +0200, Frederic Weisbecker wrote: On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote: Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger the dump of the user level stack on sample. The size of the dump is specified by sample_stack_user value. Being able to dump parts of the user stack, starting from the stack pointer, will be useful to make a post mortem dwarf CFI based stack unwinding. Signed-off-by: Jiri Olsa jo...@redhat.com Signed-off-by: Frederic Weisbecker fweis...@gmail.com please use: Signed-off-by: Jiri Olsa jo...@redhat.com Original-patch-by: Frederic Weisbecker fweis...@gmail.com If you keep the SOB of the author then you need to preserve its authorship (git am --author= / git commit --amend --author=). Unless you changed the patch significantly enough that you simply credit with something like Original-patch-by and you become the author. This is left to personal appreciation, I won't mind in any case. But there is no middle ground :) You also need to keep the SOB chain in order. The above SOB chain suggests I'm carrying a patch from you. Just saying that so that you make the maintainers job easier ;) ok, I misunderstood this one when we discussed this, sorry The userspace part have some bad ones as well.. I talked to Arnaldo how to deal with them :) thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
