Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl

[Finn Thain]

On Mon, 9 Apr 2018, Geert Uytterhoeven wrote:

> On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain  wrote:
> > The 'eject' shell command may send various different ioctl commands.
> > This leads to error messages on the console even though the FDEJECT
> > ioctl succeeds.
> >
> > ~# eject floppy
> > SWIM floppy_ioctl: unknown cmd 21257
> > SWIM floppy_ioctl: unknown cmd 1
> >
> > Don't log an error message for an invalid ioctl, just do as the
> > swim3 driver does and return -ENOTTY.
> >
> > Cc: Laurent Vivier 
> > Cc: Jens Axboe 
> > Tested-by: Stan Johnson 
> > Signed-off-by: Finn Thain 
> 
> Reviewed-by: Geert Uytterhoeven 
> 
> Looks like amiflop can use a similar fix.
> 

Right. I'll prepare a new patch for that and send it separately.

-- 

> Gr{oetje,eeting}s,
> 
> Geert
> 
> 

Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl

[Finn Thain]

On Mon, 9 Apr 2018, Geert Uytterhoeven wrote:

> On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain  wrote:
> > The 'eject' shell command may send various different ioctl commands.
> > This leads to error messages on the console even though the FDEJECT
> > ioctl succeeds.
> >
> > ~# eject floppy
> > SWIM floppy_ioctl: unknown cmd 21257
> > SWIM floppy_ioctl: unknown cmd 1
> >
> > Don't log an error message for an invalid ioctl, just do as the
> > swim3 driver does and return -ENOTTY.
> >
> > Cc: Laurent Vivier 
> > Cc: Jens Axboe 
> > Tested-by: Stan Johnson 
> > Signed-off-by: Finn Thain 
> 
> Reviewed-by: Geert Uytterhoeven 
> 
> Looks like amiflop can use a similar fix.
> 

Right. I'll prepare a new patch for that and send it separately.

-- 

> Gr{oetje,eeting}s,
> 
> Geert
> 
> 

Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl

[Geert Uytterhoeven]

On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain  wrote:
> The 'eject' shell command may send various different ioctl commands.
> This leads to error messages on the console even though the FDEJECT
> ioctl succeeds.
>
> ~# eject floppy
> SWIM floppy_ioctl: unknown cmd 21257
> SWIM floppy_ioctl: unknown cmd 1
>
> Don't log an error message for an invalid ioctl, just do as the
> swim3 driver does and return -ENOTTY.
>
> Cc: Laurent Vivier 
> Cc: Jens Axboe 
> Tested-by: Stan Johnson 
> Signed-off-by: Finn Thain 

Reviewed-by: Geert Uytterhoeven 

Looks like amiflop can use a similar fix.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl

[Geert Uytterhoeven]

On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain  wrote:
> The 'eject' shell command may send various different ioctl commands.
> This leads to error messages on the console even though the FDEJECT
> ioctl succeeds.
>
> ~# eject floppy
> SWIM floppy_ioctl: unknown cmd 21257
> SWIM floppy_ioctl: unknown cmd 1
>
> Don't log an error message for an invalid ioctl, just do as the
> swim3 driver does and return -ENOTTY.
>
> Cc: Laurent Vivier 
> Cc: Jens Axboe 
> Tested-by: Stan Johnson 
> Signed-off-by: Finn Thain 

Reviewed-by: Geert Uytterhoeven 

Looks like amiflop can use a similar fix.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds