Re: [PATCH 1/1] dm raid: fix compat_features validation

2016-10-14 Thread Heinz Mauelshagen
On 10/11/2016 07:44 PM, Mike Snitzer wrote: On Tue, Oct 11 2016 at 11:44am -0400, Heinz Mauelshagen wrote: On 10/11/2016 05:38 PM, Andy Whitcroft wrote: On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: Andy, good catch. We should rather check for V190 support only in

Re: [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Mike Snitzer
On Tue, Oct 11 2016 at 11:44am -0400, Heinz Mauelshagen wrote: > > > On 10/11/2016 05:38 PM, Andy Whitcroft wrote: > >On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: > >>Andy, > >> > >>good catch. > >> > >>We should rather check for V190 support only in case any > >>compat f

Re: [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Mike Snitzer
On Tue, Oct 11 2016 at 10:28am -0400, Andy Whitcroft wrote: > In commit ecbfb9f118bce4 ("dm raid: add raid level takeover support") a new > compatible feature flag was added. Validation for these compat_features > was added but this only passes for new raid mappings with this feature > flag. Th