Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-26 Thread Javier Gonzalez
> On 13 Feb 2018, at 13.49, Matias Bjørling wrote: > > NVMe 1.2.1 extends the get log page interface to include 64 bit > offset and increases the number of dwords to 32 bits. Implement > for future use. > > Signed-off-by: Matias Bjørling > --- >

Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-26 Thread Javier Gonzalez
> On 13 Feb 2018, at 13.49, Matias Bjørling wrote: > > NVMe 1.2.1 extends the get log page interface to include 64 bit > offset and increases the number of dwords to 32 bits. Implement > for future use. > > Signed-off-by: Matias Bjørling > --- > drivers/nvme/host/core.c | 36

Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-13 Thread Matias Bjørling
On 02/13/2018 02:47 PM, Johannes Thumshirn wrote: On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote: +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns, + u8 log_page, void *log, + size_t size, size_t offset) +{ +

Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-13 Thread Matias Bjørling
On 02/13/2018 02:47 PM, Johannes Thumshirn wrote: On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote: +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns, + u8 log_page, void *log, + size_t size, size_t offset) +{ +

Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-13 Thread Johannes Thumshirn
On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote: > +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > + u8 log_page, void *log, > + size_t size, size_t offset) > +{ > + struct nvme_command c = { }; > + unsigned long

Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

2018-02-13 Thread Johannes Thumshirn
On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote: > +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns, > + u8 log_page, void *log, > + size_t size, size_t offset) > +{ > + struct nvme_command c = { }; > + unsigned long