.com;
> > dl-linux-imx ; Anson Huang ;
> > a...@arndb.de; linux-arm-ker...@lists.infradead.org;
> > linux-kernel@vger.kernel.org
> > Cc: van.free...@gmail.com
> > Subject: RE: [PATCH 1/2] ARM: imx: drop uneccessary
> > of_platform_default_populate
> >
On Wed, Mar 13, 2019 at 09:05:52AM +, Peng Fan wrote:
> "arch_initcall_sync(of_platform_default_populate_init);" could be
The code change looks good. But can you please mention commit
44a7185c2ae6 ("of/platform: Add common method to populate default bus")
in the commit log, so that we will
d.org;
> linux-kernel@vger.kernel.org
> Cc: van.free...@gmail.com
> Subject: RE: [PATCH 1/2] ARM: imx: drop uneccessary
> of_platform_default_populate
>
> [...]
>
> > > Originally devices are registered in arch_initcall. Now it will be a
> > > bit later in arch_initcal
[...]
> > Originally devices are registered in arch_initcall. Now it will be a
> > bit later in arch_initcall_sync and this may cause a bit risk if the
> > code under the default_populate want to access the device service provided
> by early probe.
> >
> > Probably it's more safe to leave as it
d.org;
> linux-kernel@vger.kernel.org
> Cc: van.free...@gmail.com
> Subject: RE: [PATCH 1/2] ARM: imx: drop uneccessary
> of_platform_default_populate
>
> > From: Peng Fan
> >
> > "arch_initcall_sync(of_platform_default_populate_init);" could b
> From: Peng Fan
>
> "arch_initcall_sync(of_platform_default_populate_init);" could be used to
> populate the device tree, there is no need to call
> of_platform_default_populate
> in machine code.
>
> Tested on i.MX6Q-SDB i.MX6SL-EVK i.MX6UL-EVK board.
>
> Signed-off-by: Peng Fan
> ---
>
6 matches
Mail list logo
