Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-05 Thread Dmitry Torokhov
On Tue, Jun 05, 2018 at 03:50:15PM +0200, Benjamin Tissoires wrote: > On Tue, Jun 5, 2018 at 12:55 AM, Peter Hutterer > wrote: > > On Mon, Jun 04, 2018 at 02:19:44PM -0700, Dmitry Torokhov wrote: > >> On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: > >> > On Mon, Jun 4, 2018 at

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-05 Thread Benjamin Tissoires
On Tue, Jun 5, 2018 at 12:55 AM, Peter Hutterer wrote: > On Mon, Jun 04, 2018 at 02:19:44PM -0700, Dmitry Torokhov wrote: >> On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: >> > On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov >> > wrote: >> > > On Mon, Jun 04, 2018 at 03:18:12

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Tue, Jun 05, 2018 at 09:51:14AM +1000, Peter Hutterer wrote: > On Mon, Jun 04, 2018 at 04:28:01PM -0700, Dmitry Torokhov wrote: > > On Tue, Jun 05, 2018 at 09:06:24AM +1000, Peter Hutterer wrote: > > > On Mon, Jun 04, 2018 at 02:32:55PM -0700, Dmitry Torokhov wrote: > > > > On Mon, Jun 04, 2018

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
On Mon, Jun 04, 2018 at 04:28:01PM -0700, Dmitry Torokhov wrote: > On Tue, Jun 05, 2018 at 09:06:24AM +1000, Peter Hutterer wrote: > > On Mon, Jun 04, 2018 at 02:32:55PM -0700, Dmitry Torokhov wrote: > > > On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: > > > > On Mon, Jun 4, 20

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Tue, Jun 05, 2018 at 09:06:24AM +1000, Peter Hutterer wrote: > On Mon, Jun 04, 2018 at 02:32:55PM -0700, Dmitry Torokhov wrote: > > On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: > > > On Mon, Jun 4, 2018 at 8:26 PM, Dmitry Torokhov > > > wrote: > > > > On Mon, Jun 04, 2018

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
On Mon, Jun 04, 2018 at 02:32:55PM -0700, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: > > On Mon, Jun 4, 2018 at 8:26 PM, Dmitry Torokhov > > wrote: > > > On Mon, Jun 04, 2018 at 07:55:57PM +0200, Henrik Rydberg wrote: > > >> Hi Dmitry, > > >> > > >

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
On Mon, Jun 04, 2018 at 02:19:44PM -0700, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: > > On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov > > wrote: > > > On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: > > >> On Fri, Jun 1, 2018

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Mon, Jun 4, 2018 at 11:32 PM, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: >> On Mon, Jun 4, 2018 at 8:26 PM, Dmitry Torokhov >> wrote: >> > On Mon, Jun 04, 2018 at 07:55:57PM +0200, Henrik Rydberg wrote: >> >> Hi Dmitry, >> >> >> >> > > > Logica

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Mon, Jun 4, 2018 at 11:19 PM, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: >> On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov >> wrote: >> > On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: >> >> On Fri, Jun 1, 2018 at 8:43 PM,

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: > On Mon, Jun 4, 2018 at 8:26 PM, Dmitry Torokhov > wrote: > > On Mon, Jun 04, 2018 at 07:55:57PM +0200, Henrik Rydberg wrote: > >> Hi Dmitry, > >> > >> > > > Logically, the confidence state is a property of a contact, not a > >>

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: > On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov > wrote: > > On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: > >> On Fri, Jun 1, 2018 at 8:43 PM, Dmitry Torokhov > >> wrote: > >> > On Fri, Jun 01, 2018 at 04

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Mon, Jun 4, 2018 at 8:26 PM, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 07:55:57PM +0200, Henrik Rydberg wrote: >> Hi Dmitry, >> >> > > > Logically, the confidence state is a property of a contact, not a new >> > > > type >> > > > of contact. Trying to use it in any other way is bound to

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: >> On Fri, Jun 1, 2018 at 8:43 PM, Dmitry Torokhov >> wrote: >> > On Fri, Jun 01, 2018 at 04:16:09PM +0200, Benjamin Tissoires wrote: >> >> On Fri, Aug 11, 2017 at 2:44 AM,

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Mon, Jun 04, 2018 at 07:55:57PM +0200, Henrik Rydberg wrote: > Hi Dmitry, > > > > > Logically, the confidence state is a property of a contact, not a new > > > > type > > > > of contact. Trying to use it in any other way is bound to lead to > > > > confusion. > > > > > > > > Problem is that

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Henrik Rydberg
Hi Dmitry, Logically, the confidence state is a property of a contact, not a new type of contact. Trying to use it in any other way is bound to lead to confusion. Problem is that MT_TOOL_PALM has been introduced in the kernel since v4.0 (late 2015 by a736775db683 "Input: add MT_TOOL_PALM"). It'

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: > On Fri, Jun 1, 2018 at 8:43 PM, Dmitry Torokhov > wrote: > > On Fri, Jun 01, 2018 at 04:16:09PM +0200, Benjamin Tissoires wrote: > >> On Fri, Aug 11, 2017 at 2:44 AM, Dmitry Torokhov > >> wrote: > >> > According to Microsoft sp

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Dmitry Torokhov
On Mon, Jun 04, 2018 at 02:57:54PM +0200, Benjamin Tissoires wrote: > On Fri, Jun 1, 2018 at 9:03 PM, Henrik Rydberg wrote: > > > >>> However, I interpret a firmware that send (confidence 1, tip switch 1) > >>> and then (confidence 0, tip switch 0) a simple release, and the > >>> confidence bit sh

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Fri, Jun 1, 2018 at 8:43 PM, Dmitry Torokhov wrote: > On Fri, Jun 01, 2018 at 04:16:09PM +0200, Benjamin Tissoires wrote: >> On Fri, Aug 11, 2017 at 2:44 AM, Dmitry Torokhov >> wrote: >> > According to Microsoft specification [1] for Precision Touchpads (and >> > Touchscreens) the devices use

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Benjamin Tissoires
On Fri, Jun 1, 2018 at 9:03 PM, Henrik Rydberg wrote: > >>> However, I interpret a firmware that send (confidence 1, tip switch 1) >>> and then (confidence 0, tip switch 0) a simple release, and the >>> confidence bit should not be relayed. >> >> This unfortunately leads to false clicks: you start

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-01 Thread Henrik Rydberg
However, I interpret a firmware that send (confidence 1, tip switch 1) and then (confidence 0, tip switch 0) a simple release, and the confidence bit should not be relayed. This unfortunately leads to false clicks: you start with finger, so confidence is 1, then you transition the same touch t

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-01 Thread Dmitry Torokhov
On Fri, Jun 01, 2018 at 04:16:09PM +0200, Benjamin Tissoires wrote: > On Fri, Aug 11, 2017 at 2:44 AM, Dmitry Torokhov > wrote: > > According to Microsoft specification [1] for Precision Touchpads (and > > Touchscreens) the devices use "confidence" reports to signal accidental > > touches, or cont

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-01 Thread Benjamin Tissoires
On Fri, Aug 11, 2017 at 2:44 AM, Dmitry Torokhov wrote: > According to Microsoft specification [1] for Precision Touchpads (and > Touchscreens) the devices use "confidence" reports to signal accidental > touches, or contacts that are "too large to be a finger". Instead of > simply marking contact

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-01 Thread Benjamin Tissoires
On Thu, May 31, 2018 at 1:12 AM, Peter Hutterer wrote: > Hi Dmitry, > > On Thu, Aug 10, 2017 at 05:44:59PM -0700, Dmitry Torokhov wrote: >> According to Microsoft specification [1] for Precision Touchpads (and >> Touchscreens) the devices use "confidence" reports to signal accidental >> touches, o

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-05-30 Thread Peter Hutterer
Hi Dmitry, On Thu, Aug 10, 2017 at 05:44:59PM -0700, Dmitry Torokhov wrote: > According to Microsoft specification [1] for Precision Touchpads (and > Touchscreens) the devices use "confidence" reports to signal accidental > touches, or contacts that are "too large to be a finger". Instead of > sim

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2017-08-17 Thread Peter Hutterer
sorry, was at a conference/travelling and I'm slowly catching up. On Fri, Aug 11, 2017 at 10:29:07AM +0200, Henrik Rydberg wrote: > Hi Dmitry, > > > The meaning of confidence is literally "contact is too large to be a > > finger", so it is not touch state, but really tool identity. We do > > allo

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2017-08-11 Thread Henrik Rydberg
Hi Dmitry, The meaning of confidence is literally "contact is too large to be a finger", so it is not touch state, but really tool identity. We do allow tool identity to change over time. What I am arguing is rather that since "palm" is a property, just like contact size, there should be no nee

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2017-08-10 Thread Dmitry Torokhov
Hi Henrik, On Thu, Aug 10, 2017 at 11:14 PM, Henrik Rydberg wrote: > Hi Dmitry, > > On 08/11/2017 02:44 AM, Dmitry Torokhov wrote: > >> According to Microsoft specification [1] for Precision Touchpads (and >> Touchscreens) the devices use "confidence" reports to signal accidental >> touches, or c

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2017-08-10 Thread Henrik Rydberg
Hi Dmitry, On 08/11/2017 02:44 AM, Dmitry Torokhov wrote: According to Microsoft specification [1] for Precision Touchpads (and Touchscreens) the devices use "confidence" reports to signal accidental touches, or contacts that are "too large to be a finger". Instead of simply marking contact ina