Re: [PATCH 1/2] NFSD: notifiers registration cleanup

2016-09-22 Thread J. Bruce Fields
On Wed, Sep 21, 2016 at 09:20:10AM -0400, Jeff Layton wrote: > On Wed, 2016-09-21 at 15:33 +0300, Vasily Averin wrote: > > By design notifier can be registered once only, > > however nfsd registers the same inetaddr notifiers per net-namespace. > > When this happen it corrupts list of notifiers, >

Re: [PATCH 1/2] NFSD: notifiers registration cleanup

2016-09-22 Thread Vasily Averin
On 21.09.2016 16:20, Jeff Layton wrote: > Good catch. I'm not very fond of the refcounting this here but it > should > serve the purpose and I don't have anything better to suggest. FWIW, I > think the nfsd_mutex is held during all of these operations so we > probably don't need atomics for the ref

Re: [PATCH 1/2] NFSD: notifiers registration cleanup

2016-09-21 Thread Jeff Layton
On Wed, 2016-09-21 at 15:33 +0300, Vasily Averin wrote: > By design notifier can be registered once only, > however nfsd registers the same inetaddr notifiers per net-namespace. > When this happen it corrupts list of notifiers, > as result some notifiers can be not called on proper event, > travers