Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Hi Philippe On 02/09/2018 07:07 PM, Philippe Ombredanne wrote: > On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lanwrote: >> Add dt-bindings headers for the Meson-AXG's AO clock and >> reset controller. >> >> CC: >> Signed-off-by: Yixun Lan >> --- >> include/dt-bindings/clock/axg-aoclkc.h | 26 ++ >> include/dt-bindings/reset/axg-aoclkc.h | 20 >> 2 files changed, 46 insertions(+) >> create mode 100644 include/dt-bindings/clock/axg-aoclkc.h >> create mode 100644 include/dt-bindings/reset/axg-aoclkc.h >> >> diff --git a/include/dt-bindings/clock/axg-aoclkc.h >> b/include/dt-bindings/clock/axg-aoclkc.h >> new file mode 100644 >> index ..78683abb4247 >> --- /dev/null >> +++ b/include/dt-bindings/clock/axg-aoclkc.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ > > nit... BSD is not a valid license id as documented in LICENSES [1] : > please use one of these: > BSD-2-Clause or BSD-3-Clause > > Thank you! > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred > Thanks for the hint I'll update to BSD-3-Clause, since this license is just a copy from previous gxbb-aoclkc.h file. Yixun
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
Hi Philippe On 02/09/2018 07:07 PM, Philippe Ombredanne wrote: > On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan wrote: >> Add dt-bindings headers for the Meson-AXG's AO clock and >> reset controller. >> >> CC: >> Signed-off-by: Yixun Lan >> --- >> include/dt-bindings/clock/axg-aoclkc.h | 26 ++ >> include/dt-bindings/reset/axg-aoclkc.h | 20 >> 2 files changed, 46 insertions(+) >> create mode 100644 include/dt-bindings/clock/axg-aoclkc.h >> create mode 100644 include/dt-bindings/reset/axg-aoclkc.h >> >> diff --git a/include/dt-bindings/clock/axg-aoclkc.h >> b/include/dt-bindings/clock/axg-aoclkc.h >> new file mode 100644 >> index ..78683abb4247 >> --- /dev/null >> +++ b/include/dt-bindings/clock/axg-aoclkc.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ > > nit... BSD is not a valid license id as documented in LICENSES [1] : > please use one of these: > BSD-2-Clause or BSD-3-Clause > > Thank you! > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred > Thanks for the hint I'll update to BSD-3-Clause, since this license is just a copy from previous gxbb-aoclkc.h file. Yixun
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lanwrote: > Add dt-bindings headers for the Meson-AXG's AO clock and > reset controller. > > CC: > Signed-off-by: Yixun Lan > --- > include/dt-bindings/clock/axg-aoclkc.h | 26 ++ > include/dt-bindings/reset/axg-aoclkc.h | 20 > 2 files changed, 46 insertions(+) > create mode 100644 include/dt-bindings/clock/axg-aoclkc.h > create mode 100644 include/dt-bindings/reset/axg-aoclkc.h > > diff --git a/include/dt-bindings/clock/axg-aoclkc.h > b/include/dt-bindings/clock/axg-aoclkc.h > new file mode 100644 > index ..78683abb4247 > --- /dev/null > +++ b/include/dt-bindings/clock/axg-aoclkc.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne
Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings
On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan wrote: > Add dt-bindings headers for the Meson-AXG's AO clock and > reset controller. > > CC: > Signed-off-by: Yixun Lan > --- > include/dt-bindings/clock/axg-aoclkc.h | 26 ++ > include/dt-bindings/reset/axg-aoclkc.h | 20 > 2 files changed, 46 insertions(+) > create mode 100644 include/dt-bindings/clock/axg-aoclkc.h > create mode 100644 include/dt-bindings/reset/axg-aoclkc.h > > diff --git a/include/dt-bindings/clock/axg-aoclkc.h > b/include/dt-bindings/clock/axg-aoclkc.h > new file mode 100644 > index ..78683abb4247 > --- /dev/null > +++ b/include/dt-bindings/clock/axg-aoclkc.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne