Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 18:15, Ard Biesheuvel wrote: > On 8 March 2018 at 18:00, Ard Biesheuvel wrote: >> On 8 March 2018 at 16:11, Tyler Baicar wrote: >>> On 2/24/2018 2:20 AM, Dave Young wrote: On 02/23/18 at

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 18:15, Ard Biesheuvel wrote: > On 8 March 2018 at 18:00, Ard Biesheuvel wrote: >> On 8 March 2018 at 16:11, Tyler Baicar wrote: >>> On 2/24/2018 2:20 AM, Dave Young wrote: On 02/23/18 at 12:42pm, Tyler Baicar wrote: > > If ESRT initialization fails due to an

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 18:00, Ard Biesheuvel wrote: > On 8 March 2018 at 16:11, Tyler Baicar wrote: >> On 2/24/2018 2:20 AM, Dave Young wrote: >>> >>> On 02/23/18 at 12:42pm, Tyler Baicar wrote: If ESRT initialization fails due to an

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 18:00, Ard Biesheuvel wrote: > On 8 March 2018 at 16:11, Tyler Baicar wrote: >> On 2/24/2018 2:20 AM, Dave Young wrote: >>> >>> On 02/23/18 at 12:42pm, Tyler Baicar wrote: If ESRT initialization fails due to an unsupported version, the early_memremap allocation

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 16:11, Tyler Baicar wrote: > On 2/24/2018 2:20 AM, Dave Young wrote: >> >> On 02/23/18 at 12:42pm, Tyler Baicar wrote: >>> >>> If ESRT initialization fails due to an unsupported version, the >>> early_memremap allocation is never unmapped. This will

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 16:11, Tyler Baicar wrote: > On 2/24/2018 2:20 AM, Dave Young wrote: >> >> On 02/23/18 at 12:42pm, Tyler Baicar wrote: >>> >>> If ESRT initialization fails due to an unsupported version, the >>> early_memremap allocation is never unmapped. This will cause an >>> early ioremap

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Tyler Baicar
On 2/24/2018 2:20 AM, Dave Young wrote: On 02/23/18 at 12:42pm, Tyler Baicar wrote: If ESRT initialization fails due to an unsupported version, the early_memremap allocation is never unmapped. This will cause an early ioremap leak. So, make sure to unmap the memory allocation before returning

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-03-08 Thread Tyler Baicar
On 2/24/2018 2:20 AM, Dave Young wrote: On 02/23/18 at 12:42pm, Tyler Baicar wrote: If ESRT initialization fails due to an unsupported version, the early_memremap allocation is never unmapped. This will cause an early ioremap leak. So, make sure to unmap the memory allocation before returning

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-02-23 Thread Dave Young
On 02/23/18 at 12:42pm, Tyler Baicar wrote: > If ESRT initialization fails due to an unsupported version, the > early_memremap allocation is never unmapped. This will cause an > early ioremap leak. So, make sure to unmap the memory allocation > before returning from efi_esrt_init(). > >

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

2018-02-23 Thread Dave Young
On 02/23/18 at 12:42pm, Tyler Baicar wrote: > If ESRT initialization fails due to an unsupported version, the > early_memremap allocation is never unmapped. This will cause an > early ioremap leak. So, make sure to unmap the memory allocation > before returning from efi_esrt_init(). > >