Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
Michal, All, On Tue, Apr 16, 2013 at 11:12:41AM +0200, Michal Marek wrote: > > On 15.4.2013 23:54, Yann E. MORIN wrote: > >> So, unless Michal really wants to pull this one and push it to Linus > >> before he cuts v3.9 final, I'll merge this later in my -for-next branch. > BTW, in you are going to rebase the commit, it would be good idea to add > Cc: to the changelog. Yes sure. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
On 16.4.2013 10:21, Michal Marek wrote: > On 15.4.2013 23:54, Yann E. MORIN wrote: >> So, unless Michal really wants to pull this one and push it to Linus >> before he cuts v3.9 final, I'll merge this later in my -for-next branch. > > That's fine with me. BTW, in you are going to rebase the commit, it would be good idea to add Cc: to the changelog. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
On 15.4.2013 23:54, Yann E. MORIN wrote: > So, unless Michal really wants to pull this one and push it to Linus > before he cuts v3.9 final, I'll merge this later in my -for-next branch. That's fine with me. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
On 15.4.2013 23:54, Yann E. MORIN wrote: So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. That's fine with me. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
On 16.4.2013 10:21, Michal Marek wrote: On 15.4.2013 23:54, Yann E. MORIN wrote: So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. That's fine with me. BTW, in you are going to rebase the commit, it would be good idea to add Cc: sta...@vger.kernel.org to the changelog. Thanks, Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
Michal, All, On Tue, Apr 16, 2013 at 11:12:41AM +0200, Michal Marek wrote: On 15.4.2013 23:54, Yann E. MORIN wrote: So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. BTW, in you are going to rebase the commit, it would be good idea to add Cc: sta...@vger.kernel.org to the changelog. Yes sure. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
Benjamin, All, On Mon, Apr 15, 2013 at 10:13:50AM -0400, Benjamin Poirier wrote: > Fixes the memory leak of struct jump_key allocated in get_prompt_str() Queued into: https://git.gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-rc-fixes Although this is strictly a bug fix, I would lean toward waiting for the next merge window to open before pulling this in. We can't really say that the kconfig frontends are critical, long-running processes. If they leak a bit of memory, that's not too cumbersome, I think. OTOH, I think breaking the frontends so close to the end of the -rc cycle is a bit dangerous (heck, I would not like to be part of the cause of a new flaming, just for this! ;-) ) So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. Thank you! Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature
Benjamin, All, On Mon, Apr 15, 2013 at 10:13:50AM -0400, Benjamin Poirier wrote: Fixes the memory leak of struct jump_key allocated in get_prompt_str() Queued into: https://git.gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-rc-fixes Although this is strictly a bug fix, I would lean toward waiting for the next merge window to open before pulling this in. We can't really say that the kconfig frontends are critical, long-running processes. If they leak a bit of memory, that's not too cumbersome, I think. OTOH, I think breaking the frontends so close to the end of the -rc cycle is a bit dangerous (heck, I would not like to be part of the cause of a new flaming, just for this! ;-) ) So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. Thank you! Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
