Re: [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering

2018-04-17 Thread Sandipan Das
On 04/17/2018 12:29 PM, Ravi Bangoria wrote: > > This change looks good to me but seems it fixed the issue > partially.Ex, > >     # readelf --debug-dump=frames-interp /lib64/libc-2.26.so | less >     ... >     5778 0024 577c FDE cie= > pc=00048b30..0

Re: [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering

2018-04-17 Thread Ravi Bangoria
On 04/12/2018 10:41 PM, Sandipan Das wrote: > For powerpc64, if a probe is added for a function without specifying > a line number, the corresponding trap instruction is placed at offset > 0 (for big endian) or 8 (for little endian) from the start address of > the function. This address is in the

Re: [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering

2018-04-12 Thread Sandipan Das
On 04/13/2018 12:13 AM, Arnaldo Carvalho de Melo wrote: > > So, the author for the fixed-by patch here is Sukadev Bhattiprolu > , and the reporter for the problem that > patch fixed is Maynard Johnson , who also tested > that patch, I think it'd be better if they get CCed to have the > opportuni

Re: [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering

2018-04-12 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 12, 2018 at 10:41:28PM +0530, Sandipan Das escreveu: > For powerpc64, if a probe is added for a function without specifying > a line number, the corresponding trap instruction is placed at offset > 0 (for big endian) or 8 (for little endian) from the start address of > the function. Thi