Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-04-03 Thread Rajat Jain
On Fri, Mar 29, 2019 at 8:53 AM Srinivas Pandruvada wrote: > > On Thu, 2019-03-28 at 22:29 -0700, Rajat Jain wrote: > > Hi Srinivas, > > > > > > [...] > > > So if everyone here thinks we should completely switch to using > > > > the > > > > ACPI HID "INT33A1" for attaching to the device, sure, we

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-29 Thread Srinivas Pandruvada
On Thu, 2019-03-28 at 22:29 -0700, Rajat Jain wrote: > Hi Srinivas, > > [...] > So if everyone here thinks we should completely switch to using > > > the > > > ACPI HID "INT33A1" for attaching to the device, sure, we can do > > > that. > > > Yes, for Chromeos, we can put in a work around intern

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-28 Thread Rajat Jain
Hi Srinivas, On Thu, Mar 28, 2019 at 8:41 PM Srinivas Pandruvada wrote: > > On Mon, 2019-03-25 at 18:41 -0700, Rajat Jain wrote: > > Hi Rajneesh, > > > > > > On Mon, Mar 25, 2019 at 3:23 AM Bhardwaj, Rajneesh > > wrote: > > > > > > Hi Rajat > > > > > > On 23-Mar-19 6:00 AM, Rajat Jain wrote: >

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-28 Thread Srinivas Pandruvada
On Mon, 2019-03-25 at 18:41 -0700, Rajat Jain wrote: > Hi Rajneesh, > > > On Mon, Mar 25, 2019 at 3:23 AM Bhardwaj, Rajneesh > wrote: > > > > Hi Rajat > > > > On 23-Mar-19 6:00 AM, Rajat Jain wrote: > > > Hi Rajneesh, > > > > > > > > > > > > On Fri, Mar 22, 2019 at 12:56 PM Bhardwaj, Rajnee

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-25 Thread Rajat Jain
Hi Rajneesh, On Mon, Mar 25, 2019 at 3:23 AM Bhardwaj, Rajneesh wrote: > > Hi Rajat > > On 23-Mar-19 6:00 AM, Rajat Jain wrote: > > Hi Rajneesh, > > > > > > > > On Fri, Mar 22, 2019 at 12:56 PM Bhardwaj, Rajneesh > > wrote: > >> Some suggestions below > >> > >> On 18-Mar-19 8:36 PM, Rajat Jain

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-25 Thread Bhardwaj, Rajneesh
Hi Rajat On 23-Mar-19 6:00 AM, Rajat Jain wrote: Hi Rajneesh, On Fri, Mar 22, 2019 at 12:56 PM Bhardwaj, Rajneesh wrote: Some suggestions below On 18-Mar-19 8:36 PM, Rajat Jain wrote: On Sat, Mar 16, 2019 at 1:30 AM Rajneesh Bhardwaj wrote: On Wed, Mar 13, 2019 at 03:21:23PM -0700, Raja

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-22 Thread Rajat Jain
Hi Rajneesh, On Fri, Mar 22, 2019 at 12:56 PM Bhardwaj, Rajneesh wrote: > > Some suggestions below > > On 18-Mar-19 8:36 PM, Rajat Jain wrote: > > On Sat, Mar 16, 2019 at 1:30 AM Rajneesh Bhardwaj > wrote: > > On Wed, Mar 13, 2019 at 03:21:23PM -0700, Rajat Jain wrote: > > Convert the intel_pm

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-18 Thread Rajat Jain
On Sat, Mar 16, 2019 at 1:30 AM Rajneesh Bhardwaj wrote: > > On Wed, Mar 13, 2019 at 03:21:23PM -0700, Rajat Jain wrote: > > Convert the intel_pmc_core driver to a platform driver. There is no > > functional change. Some code that tries to determine what kind of > > CPU this is, has been moved cod

Re: [PATCH 1/2] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-03-16 Thread Rajneesh Bhardwaj
On Wed, Mar 13, 2019 at 03:21:23PM -0700, Rajat Jain wrote: > Convert the intel_pmc_core driver to a platform driver. There is no > functional change. Some code that tries to determine what kind of > CPU this is, has been moved code is moved from pmc_core_probe() to Possible typo here. > pmc_core