Re: [PATCH 1/2] sched/fair: Consider SD_NUMA when selecting the most idle group to schedule on

2018-02-13 Thread Mel Gorman
On Tue, Feb 13, 2018 at 02:04:45PM +0100, Peter Zijlstra wrote: > On Tue, Feb 13, 2018 at 11:35:48AM +, Mel Gorman wrote: > > > However, if we have numa balancing enabled, that will counteract > > > the normal spreading across nodes, so in that regard it makes sense, but > > > the above code is

Re: [PATCH 1/2] sched/fair: Consider SD_NUMA when selecting the most idle group to schedule on

2018-02-13 Thread Peter Zijlstra
On Tue, Feb 13, 2018 at 11:35:48AM +, Mel Gorman wrote: > > However, if we have numa balancing enabled, that will counteract > > the normal spreading across nodes, so in that regard it makes sense, but > > the above code is not conditional on numa balancing. > > > > It's not conditional on NU

Re: [PATCH 1/2] sched/fair: Consider SD_NUMA when selecting the most idle group to schedule on

2018-02-13 Thread Mel Gorman
On Tue, Feb 13, 2018 at 11:45:41AM +0100, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 05:11:30PM +, Mel Gorman wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 50442697b455..0192448e43a2 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -59

Re: [PATCH 1/2] sched/fair: Consider SD_NUMA when selecting the most idle group to schedule on

2018-02-13 Thread Peter Zijlstra
On Mon, Feb 12, 2018 at 05:11:30PM +, Mel Gorman wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 50442697b455..0192448e43a2 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5917,6 +5917,18 @@ find_idlest_group(struct sched_domain *sd, struct > task_s