Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities

2016-10-21 Thread Jarkko Sakkinen
On Fri, Oct 21, 2016 at 11:33:44PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 19, 2016 at 05:24:06PM -0600, Jason Gunthorpe wrote: > > On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote: > > > From: Ed Swierk > > > > > > Call tpm_getcap() from tpm_get_timeouts() to eliminate redunda

Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities

2016-10-21 Thread Jarkko Sakkinen
On Mon, Sep 19, 2016 at 05:24:06PM -0600, Jason Gunthorpe wrote: > On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote: > > From: Ed Swierk > > > > Call tpm_getcap() from tpm_get_timeouts() to eliminate redundant > > code. Return all errors to the caller rather than swallowing them >

Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities

2016-09-19 Thread Jason Gunthorpe
On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote: > From: Ed Swierk > > Call tpm_getcap() from tpm_get_timeouts() to eliminate redundant > code. Return all errors to the caller rather than swallowing them > (e.g. when tpm_transmit_cmd() returns nonzero). I didn't look at these clo