Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow

2019-09-13 Thread Guenter Roeck
On Fri, Sep 06, 2019 at 10:30:53PM +0200, Jorge Ramirez-Ortiz wrote: > When an IRQ is present in the dts, the probe function shall fail if > the interrupt can not be registered. > > The probe function shall also be retried if getting the irq is being > deferred. > > Signed-off-by: Jorge

Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow

2019-09-13 Thread Loic Poulain
On Wed, 11 Sep 2019 at 19:54, Guenter Roeck wrote: > > On Wed, Sep 11, 2019 at 10:04:12AM +0200, Loic Poulain wrote: > > Hi Guenter, Jorge, > > > > On Mon, 9 Sep 2019 at 00:50, Guenter Roeck wrote: > > > > > On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote: > > > > When an IRQ is present in the dts,

Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow

2019-09-11 Thread Guenter Roeck
On Wed, Sep 11, 2019 at 10:04:12AM +0200, Loic Poulain wrote: > Hi Guenter, Jorge, > > On Mon, 9 Sep 2019 at 00:50, Guenter Roeck wrote: > > > On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote: > > > When an IRQ is present in the dts, the probe function shall fail if > > > the interrupt can not be

Re: [PATCH 1/2] watchdog: pm8916_wdt: fix pretimeout registration flow

2019-09-08 Thread Guenter Roeck
On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote: When an IRQ is present in the dts, the probe function shall fail if the interrupt can not be registered. The author intended differently, and did not want registration to fail in this situation, following the logic that it is better to have a