Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-20 Thread Xishi Qiu
On 2015/4/21 2:23, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 11:42:10 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: >> >>> >>> On Mon, 20 Apr 2015 10:45:45 +0800 >>> Xishi Qiu wrote: >>> On 2015/4/20 9:42, Gu Zheng wrote: > Hi Xishi, > On

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-20 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 11:42:10 +0800 Xishi Qiu wrote: > On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: > > > > > On Mon, 20 Apr 2015 10:45:45 +0800 > > Xishi Qiu wrote: > > > >> On 2015/4/20 9:42, Gu Zheng wrote: > >> > >>> Hi Xishi, > >>> On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > >>>

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-20 Thread Xishi Qiu
On 2015/4/21 2:23, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 11:42:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-20 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 11:42:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 10:45:45 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 9:42, Gu Zheng wrote: >> >>> Hi Xishi, >>> On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: >>> Your patches will fix your issue. But, if BIOS reports memory

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 11:15, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 10:59:37 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 10:09, Gu Zheng wrote: >> >>> Hi Ishimatsu, Xishi, >>> >>> On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: >>> > When hot adding memory and creating new node, the

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu wrote: > On 2015/4/20 9:42, Gu Zheng wrote: > > > Hi Xishi, > > On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > > > >> > >> Your patches will fix your issue. > >> But, if BIOS reports memory first at node hot add, pgdat can > >> not be

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:59:37 +0800 Xishi Qiu wrote: > On 2015/4/20 10:09, Gu Zheng wrote: > > > Hi Ishimatsu, Xishi, > > > > On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > > > >> > >>> When hot adding memory and creating new node, the node is offline. > >>> And after calling

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 9:42, Gu Zheng wrote: > Hi Xishi, > On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > >> >> Your patches will fix your issue. >> But, if BIOS reports memory first at node hot add, pgdat can >> not be initialized. >> >> Memory hot add flows are as follows: >> >> add_memory >> ...

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 10:09, Gu Zheng wrote: > Hi Ishimatsu, Xishi, > > On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> >>> When hot adding memory and creating new node, the node is offline. >>> And after calling node_set_online(), the node becomes online. >>> >>> Oh, sorry. I misread your

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> When hot adding memory and creating new node, the node is offline. >> And after calling node_set_online(), the node becomes online. >> >> Oh, sorry. I misread your ptaches. >> > > Please ignore it... Seems also a

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> When hot adding memory and creating new node, the node is offline. >> And after calling node_set_online(), the node becomes online. >> >> Oh, sorry. I misread your ptaches. >> > > Please ignore it... Seems also a

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > > > > Your patches will fix your issue. > > But, if BIOS reports memory first at node hot add, pgdat can > > not be initialized. > > > > Memory hot add flows are as follows: > > > >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
> When hot adding memory and creating new node, the node is offline. > And after calling node_set_online(), the node becomes online. > > Oh, sorry. I misread your ptaches. > Please ignore it... Thanks, Yasuaki Ishimatsu On Yasuaki Ishimatsu wrote: > > When hot adding memory and creating

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > > Your patches will fix your issue. > But, if BIOS reports memory first at node hot add, pgdat can > not be initialized. > > Memory hot add flows are as follows: > > add_memory > ... > -> hotadd_new_pgdat() > ... > ->

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > Your patches will fix your issue. > But, if BIOS reports memory first at node hot add, pgdat can > not be initialized. > > Memory hot add flows are as follows: > > add_memory > ... > -> hotadd_new_pgdat() > ... > -> node_set_online(nid) >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Please ignore it... Thanks, Yasuaki Ishimatsu On Yasuaki Ishimatsu yasu.isim...@gmail.com wrote: When hot adding

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... - hotadd_new_pgdat() ... - node_set_online(nid) When calling

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Please ignore it... Seems also a misread to me. I

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Please ignore it... Seems also a misread to me. I

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 10:09, Gu Zheng wrote: Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Please ignore

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... -

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 11:15, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 10:59:37 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 10:09, Gu Zheng wrote: Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/18 4:05, Yasuaki

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Gu Zheng
Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... - hotadd_new_pgdat() ... - node_set_online(nid)

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows:

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:59:37 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 10:09, Gu Zheng wrote: Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: When hot adding memory and creating new node, the node is offline. And after calling

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Yasuaki Ishimatsu
On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-19 Thread Xishi Qiu
On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On 2015/4/20 9:42, Gu Zheng wrote: Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: Your patches will fix your issue. But, if BIOS reports memory first at

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-17 Thread Yasuaki Ishimatsu
Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... -> hotadd_new_pgdat() ... -> node_set_online(nid) When calling hotadd_new_pgdat() for a hot added node, the node is

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

2015-04-17 Thread Yasuaki Ishimatsu
Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... - hotadd_new_pgdat() ... - node_set_online(nid) When calling hotadd_new_pgdat() for a hot added node, the node is