Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-03-09 Thread Boaz Harrosh
On 03/05/2015 10:41 PM, Dan Williams wrote: > On Thu, Mar 5, 2015 at 2:20 AM, Boaz Harrosh wrote: >> >> There is something not very nice (Gentlemen nice) In current >> e820.c code. >> >> At Multiple places for example @memblock_x86_fill() it will >> add the different memory resources *except the E

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-03-05 Thread Dan Williams
On Thu, Mar 5, 2015 at 2:20 AM, Boaz Harrosh wrote: > > There is something not very nice (Gentlemen nice) In current > e820.c code. > > At Multiple places for example @memblock_x86_fill() it will > add the different memory resources *except the E820_RESERVED type* > > Then at e820_reserve_resource

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-02-25 Thread Dan Williams
On Mon, Feb 23, 2015 at 11:59 PM, Boaz Harrosh wrote: > No, this is a complete HACK, since when do we hard code specific (GLOBAL) > ARCHs strings in common code. Please look at linux/ioport.h see the richness > of options for all kind of buses and systems. The flag system works perfectly > and I j

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-02-24 Thread Boaz Harrosh
On 02/24/2015 10:34 AM, Ingo Molnar wrote: > > * Boaz Harrosh wrote: > >> On 02/24/2015 06:22 AM, Dan Williams wrote: >> <> By Popular demand An Extra WARNING message is printed if an "UNKNOWN" is found. It will look like this: e820: WARNING [mem 0x1-0x1] is unkn

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-02-24 Thread Ingo Molnar
* Boaz Harrosh wrote: > On 02/24/2015 06:22 AM, Dan Williams wrote: > <> > >> By Popular demand An Extra WARNING message is printed if > >> an "UNKNOWN" is found. It will look like this: > >> e820: WARNING [mem 0x1-0x1] is unknown type 12 > > > > I don't think we need to warn

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-02-24 Thread Boaz Harrosh
On 02/24/2015 06:22 AM, Dan Williams wrote: <> >> By Popular demand An Extra WARNING message is printed if >> an "UNKNOWN" is found. It will look like this: >> e820: WARNING [mem 0x1-0x1] is unknown type 12 > > I don't think we need to warn that an unknown range was published, ju

Re: [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY

2015-02-23 Thread Dan Williams
On Mon, 2015-02-23 at 14:33 +0200, Boaz Harrosh wrote: > There is something not very nice (Gentlemen nice) In current > e820.c code. > > At Multiple places for example like (@ memblock_x86_fill()) it will > add the different memory resources *except the E820_RESERVED type* > > Then at e820_reserv