Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-26 Thread Thierry Reding
On Mon, Aug 25, 2014 at 04:40:57PM -0700, Doug Anderson wrote: [...] > I was doing some thinking about what to do, then. I wondered whether > the right thing to do is not to make a "rk3288 syscon" driver that > configures these bits, but rather to make a "rk3288" driver has access > to the

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-26 Thread Thierry Reding
On Mon, Aug 25, 2014 at 04:40:57PM -0700, Doug Anderson wrote: [...] I was doing some thinking about what to do, then. I wondered whether the right thing to do is not to make a rk3288 syscon driver that configures these bits, but rather to make a rk3288 driver has access to the syscon. It

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-25 Thread Doug Anderson
Thierry, On Thu, Aug 21, 2014 at 9:47 AM, Thierry Reding wrote: > On Thu, Aug 21, 2014 at 08:38:57AM -0700, Doug Anderson wrote: >> Thierry, >> >> On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding >> wrote: >> > On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: >> >> Am Mittwoch,

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-25 Thread Doug Anderson
Thierry, On Thu, Aug 21, 2014 at 9:47 AM, Thierry Reding thierry.red...@gmail.com wrote: On Thu, Aug 21, 2014 at 08:38:57AM -0700, Doug Anderson wrote: Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Thu, Aug 21, 2014 at 05:49:22PM +0200, Tomasz Figa wrote: > On 21.08.2014 17:38, Doug Anderson wrote: > > Thierry, > > > > On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding > > wrote: > >> On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: > >>> Am Mittwoch, 20. August 2014,

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Thu, Aug 21, 2014 at 08:38:57AM -0700, Doug Anderson wrote: > Thierry, > > On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding > wrote: > > On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: > >> Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: > >> > Thierry, > >> > >

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Heiko Stübner
Am Donnerstag, 21. August 2014, 08:24:22 schrieb Thierry Reding: > On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: > > On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding wrote: > [...] > > > > Looking at the register offsets in the device tree that seems likely. At > > > least PWMs

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Tomasz Figa
On 21.08.2014 17:38, Doug Anderson wrote: > Thierry, > > On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding > wrote: >> On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: >>> Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Doug Anderson
Thierry and Heiko On Wed, Aug 20, 2014 at 11:24 PM, Thierry Reding wrote: > On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: >> On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding >> wrote: > [...] >> > Looking at the register offsets in the device tree that seems likely. At >> >

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding wrote: > On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: >> Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: >> > Thierry, >> > >> > On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding >> > >> > wrote: >> > > On

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: > Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: > > Thierry, > > > > On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding > > > > wrote: > > > On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: > > >> Thierry,

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: > On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding > wrote: [...] > > Looking at the register offsets in the device tree that seems likely. At > > least PWMs 0 and 1 as well as 2 and 3 seem like they could be in the > > same IP block.

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: [...] Looking at the register offsets in the device tree that seems likely. At least PWMs 0 and 1 as well as 2 and 3 seem like they could be in the

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote:

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Doug Anderson
Thierry and Heiko On Wed, Aug 20, 2014 at 11:24 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: [...] Looking at the register offsets in the

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Tomasz Figa
On 21.08.2014 17:38, Doug Anderson wrote: Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Heiko Stübner
Am Donnerstag, 21. August 2014, 08:24:22 schrieb Thierry Reding: On Wed, Aug 20, 2014 at 08:55:09AM -0700, Doug Anderson wrote: On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: [...] Looking at the register offsets in the device tree that seems likely. At

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Thu, Aug 21, 2014 at 08:38:57AM -0700, Doug Anderson wrote: Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry,

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-21 Thread Thierry Reding
On Thu, Aug 21, 2014 at 05:49:22PM +0200, Tomasz Figa wrote: On 21.08.2014 17:38, Doug Anderson wrote: Thierry, On Wed, Aug 20, 2014 at 11:36 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 06:20:31PM +0200, Heiko Stübner wrote: Am Mittwoch, 20. August

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Heiko, On Wed, Aug 20, 2014 at 11:03 AM, Heiko Stübner wrote: > Am Mittwoch, 20. August 2014, 09:27:02 schrieb Doug Anderson: >> Heiko, >> >> On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner wrote: >> > Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: >> >> Thierry, >> >> >> >> On

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Heiko Stübner
Am Mittwoch, 20. August 2014, 09:27:02 schrieb Doug Anderson: > Heiko, > > On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner wrote: > > Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: > >> Thierry, > >> > >> On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding > >> > >> wrote: > >> > On

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Heiko, On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner wrote: > Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: >> Thierry, >> >> On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding >> >> wrote: >> > On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: >> >> Thierry, >> >> >>

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Heiko Stübner
Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: > Thierry, > > On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding > > wrote: > > On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: > >> Thierry, > >> > >> On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding > >> > >> wrote:

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding wrote: > On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: >> Thierry, >> >> On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding >> wrote: >> > On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: >> >> Thierry, >> >>

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Thierry Reding
On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: > Thierry, > > On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding > wrote: > > On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: > >> Thierry, > >> > >> On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding > >> wrote: > >> >

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Thierry, On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding wrote: > On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: >> Thierry, >> >> On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding >> wrote: >> > On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: >> >> The rk3288 SoC

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Thierry Reding
On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: > Thierry, > > On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding > wrote: > > On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: > >> The rk3288 SoC has an option to switch all of the PWMs in the system > >> between the

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Thierry Reding
On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding thierry.red...@gmail.com wrote: On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: The rk3288 SoC has an option to switch all of the PWMs in the system

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Thierry, On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding thierry.red...@gmail.com wrote: On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Thierry Reding
On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Aug 19, 2014 at 08:18:54AM -0700, Doug

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Heiko Stübner
Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson wrote: Thierry, On Tue, Aug 19, 2014 at 11:08 PM, Thierry Reding

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Heiko, On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 20, 2014 at 08:20:53AM -0700, Doug Anderson

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Heiko Stübner
Am Mittwoch, 20. August 2014, 09:27:02 schrieb Doug Anderson: Heiko, On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry, On Wed, Aug 20, 2014 at 8:38 AM, Thierry Reding

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-20 Thread Doug Anderson
Heiko, On Wed, Aug 20, 2014 at 11:03 AM, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 20. August 2014, 09:27:02 schrieb Doug Anderson: Heiko, On Wed, Aug 20, 2014 at 9:20 AM, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 20. August 2014, 08:55:09 schrieb Doug Anderson: Thierry,

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-19 Thread Doug Anderson
Thierry, On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding wrote: > On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: >> The rk3288 SoC has an option to switch all of the PWMs in the system >> between the old IP block and the new IP block. The new IP block is >> working and tested

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-19 Thread Thierry Reding
On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: > The rk3288 SoC has an option to switch all of the PWMs in the system > between the old IP block and the new IP block. The new IP block is > working and tested and the suggested PWM to use, so setup the SoC to > use it and then we

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-19 Thread Thierry Reding
On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: The rk3288 SoC has an option to switch all of the PWMs in the system between the old IP block and the new IP block. The new IP block is working and tested and the suggested PWM to use, so setup the SoC to use it and then we can

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-19 Thread Doug Anderson
Thierry, On Tue, Aug 19, 2014 at 12:10 AM, Thierry Reding thierry.red...@gmail.com wrote: On Mon, Aug 18, 2014 at 10:09:06AM -0700, Doug Anderson wrote: The rk3288 SoC has an option to switch all of the PWMs in the system between the old IP block and the new IP block. The new IP block is

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-18 Thread Doug Anderson
Sonny, On Mon, Aug 18, 2014 at 10:11 AM, Sonny Rao wrote: > On Mon, Aug 18, 2014 at 10:09 AM, Doug Anderson wrote: >> The rk3288 SoC has an option to switch all of the PWMs in the system >> between the old IP block and the new IP block. The new IP block is >> working and tested and the

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-18 Thread Sonny Rao
On Mon, Aug 18, 2014 at 10:09 AM, Doug Anderson wrote: > The rk3288 SoC has an option to switch all of the PWMs in the system > between the old IP block and the new IP block. The new IP block is > working and tested and the suggested PWM to use, so setup the SoC to > use it and then we can

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-18 Thread Sonny Rao
On Mon, Aug 18, 2014 at 10:09 AM, Doug Anderson diand...@chromium.org wrote: The rk3288 SoC has an option to switch all of the PWMs in the system between the old IP block and the new IP block. The new IP block is working and tested and the suggested PWM to use, so setup the SoC to use it and

Re: [PATCH 1/4] ARM: rockchip: rk3288: Switch to use the proper PWM IP

2014-08-18 Thread Doug Anderson
Sonny, On Mon, Aug 18, 2014 at 10:11 AM, Sonny Rao sonny...@chromium.org wrote: On Mon, Aug 18, 2014 at 10:09 AM, Doug Anderson diand...@chromium.org wrote: The rk3288 SoC has an option to switch all of the PWMs in the system between the old IP block and the new IP block. The new IP block is