Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Apr 04, 2017 at 06:56:30AM -0700, Tony Lindgren wrote: > * Mark Brown [170404 05:22]: > > It is sadly far too common for people to implement interrupt controllers > > that only do edge triggers, I've no idea why even on what are supposed > > to be relatively high end

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Apr 04, 2017 at 06:56:30AM -0700, Tony Lindgren wrote: > * Mark Brown [170404 05:22]: > > It is sadly far too common for people to implement interrupt controllers > > that only do edge triggers, I've no idea why even on what are supposed > > to be relatively high end SoCs. It seems to

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170404 05:22]: > On Mon, Apr 03, 2017 at 08:03:00PM -0700, Tony Lindgren wrote: > > > So I'll drop the genirq/regmap_irq related hacks and resend just > > the minimal MFD fixes. Similar misconfiguration may be the root > > cause for other drivers too.. > > It

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170404 05:22]: > On Mon, Apr 03, 2017 at 08:03:00PM -0700, Tony Lindgren wrote: > > > So I'll drop the genirq/regmap_irq related hacks and resend just > > the minimal MFD fixes. Similar misconfiguration may be the root > > cause for other drivers too.. > > It is sadly far too

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Apr 03, 2017 at 08:03:00PM -0700, Tony Lindgren wrote: > So I'll drop the genirq/regmap_irq related hacks and resend just > the minimal MFD fixes. Similar misconfiguration may be the root > cause for other drivers too.. It is sadly far too common for people to implement interrupt

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Apr 03, 2017 at 08:03:00PM -0700, Tony Lindgren wrote: > So I'll drop the genirq/regmap_irq related hacks and resend just > the minimal MFD fixes. Similar misconfiguration may be the root > cause for other drivers too.. It is sadly far too common for people to implement interrupt

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

Hi, * Tony Lindgren [170328 10:13]: > * Mark Brown [170328 09:51]: > > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > > * Mark Brown [170328 08:21]: > > > > > > Right, my thinking here is that by pushing into genirq

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

Hi, * Tony Lindgren [170328 10:13]: > * Mark Brown [170328 09:51]: > > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > > * Mark Brown [170328 08:21]: > > > > > > Right, my thinking here is that by pushing into genirq we minimise the > > > > need even further since it'll

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Wed, 22 Mar 2017, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. This seems to be a bug in the > CPCAP PMIC where it can stop driving the

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Wed, 22 Mar 2017, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. This seems to be a bug in the > CPCAP PMIC where it can stop driving the

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170328 09:51]: > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > * Mark Brown [170328 08:21]: > > > > Right, my thinking here is that by pushing into genirq we minimise the > > > need even further since it'll also be

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170328 09:51]: > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > * Mark Brown [170328 08:21]: > > > > Right, my thinking here is that by pushing into genirq we minimise the > > > need even further since it'll also be available to drivers not using > > >

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > * Mark Brown [170328 08:21]: > > Right, my thinking here is that by pushing into genirq we minimise the > > need even further since it'll also be available to drivers not using > > regmap-irq. > > > like,

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > * Mark Brown [170328 08:21]: > > Right, my thinking here is that by pushing into genirq we minimise the > > need even further since it'll also be available to drivers not using > > regmap-irq. > > > like, handle until we get

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170328 08:21]: > On Mon, Mar 27, 2017 at 05:36:48PM -0700, Tony Lindgren wrote: > > * Mark Brown [170327 10:52]: > > > > So, I see your use case but the fact is that as Charles observed this is > > > exactly the code used for emulating level

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170328 08:21]: > On Mon, Mar 27, 2017 at 05:36:48PM -0700, Tony Lindgren wrote: > > * Mark Brown [170327 10:52]: > > > > So, I see your use case but the fact is that as Charles observed this is > > > exactly the code used for emulating level triggered IRQs with edge > > >

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Mar 27, 2017 at 05:36:48PM -0700, Tony Lindgren wrote: > * Mark Brown [170327 10:52]: > > So, I see your use case but the fact is that as Charles observed this is > > exactly the code used for emulating level triggered IRQs with edge > > triggered interrupt

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Mar 27, 2017 at 05:36:48PM -0700, Tony Lindgren wrote: > * Mark Brown [170327 10:52]: > > So, I see your use case but the fact is that as Charles observed this is > > exactly the code used for emulating level triggered IRQs with edge > > triggered interrupt controllers. This means

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170327 10:52]: > On Wed, Mar 22, 2017 at 10:10:49AM -0700, Tony Lindgren wrote: > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > until there are no more interrupts. Otherwise the PMIC interrupt to > > the SoC will eventually stop

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Mark Brown [170327 10:52]: > On Wed, Mar 22, 2017 at 10:10:49AM -0700, Tony Lindgren wrote: > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > until there are no more interrupts. Otherwise the PMIC interrupt to > > the SoC will eventually stop toggling. This seems to be a

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Wed, Mar 22, 2017 at 10:10:49AM -0700, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. This seems to be a bug in the > CPCAP PMIC where it can

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Wed, Mar 22, 2017 at 10:10:49AM -0700, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. This seems to be a bug in the > CPCAP PMIC where it can

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Mar 21, 2017 at 08:41:22AM -0700, Tony Lindgren wrote: > * Charles Keepax [170321 02:24]: > > On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > > > * Charles Keepax [170320 08:15]: > > > > On Thu,

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Tue, Mar 21, 2017 at 08:41:22AM -0700, Tony Lindgren wrote: > * Charles Keepax [170321 02:24]: > > On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > > > * Charles Keepax [170320 08:15]: > > > > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > That sounds a lot

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Charles Keepax [170321 02:24]: > On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > > * Charles Keepax [170320 08:15]: > > > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > > > At least

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Charles Keepax [170321 02:24]: > On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > > * Charles Keepax [170320 08:15]: > > > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > > > until

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > * Charles Keepax [170320 08:15]: > > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > > until there are

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Mon, Mar 20, 2017 at 08:33:42AM -0700, Tony Lindgren wrote: > * Charles Keepax [170320 08:15]: > > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > > until there are no more interrupts. Otherwise the PMIC

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Charles Keepax [170320 08:15]: > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > until there are no more interrupts. Otherwise the PMIC interrupt to > > the SoC will

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

* Charles Keepax [170320 08:15]: > On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > > At least Motorola CPCAP PMIC needs it's device interrupts re-read > > until there are no more interrupts. Otherwise the PMIC interrupt to > > the SoC will eventually stop toggling. > > > > Let's

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. > > Let's allow doing that by introducing a flag for

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

On Thu, Mar 16, 2017 at 05:36:30PM -0700, Tony Lindgren wrote: > At least Motorola CPCAP PMIC needs it's device interrupts re-read > until there are no more interrupts. Otherwise the PMIC interrupt to > the SoC will eventually stop toggling. > > Let's allow doing that by introducing a flag for