Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 09:36:36 PM Luck, Tony wrote: > > The BIOSes of currently available ia64 systems don't contain ACPI nodes > > whose > > IDs will match the IDs of the new devices (ie. the ones that are going to be > > added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to > > test that code as is (ie. without any new devices in the system). > > Ok - built cleanly on ia64. Boots too. Just one new console message: > > ACPI: bus type platform registered > > that seems pretty harmless. > > Acked-by: Tony Luck Thanks a lot! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
> The BIOSes of currently available ia64 systems don't contain ACPI nodes whose > IDs will match the IDs of the new devices (ie. the ones that are going to be > added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to > test that code as is (ie. without any new devices in the system). Ok - built cleanly on ia64. Boots too. Just one new console message: ACPI: bus type platform registered that seems pretty harmless. Acked-by: Tony Luck
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wed, Oct 31, 2012 at 10:06:00PM +0100, Rafael J. Wysocki wrote: > On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: > > > By "tested" I mean "run with some new devices that use the ACPI > > > enumeration > > > provided here, on x86". Sorry for being too vague. > > > > Do you or Mika have access to an ia64 box to test. > > I don't. I'm not sure about Mika. I also don't have access to any ia64 machine. As Rafael said, I tested this on x86 machine only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: > > By "tested" I mean "run with some new devices that use the ACPI enumeration > > provided here, on x86". Sorry for being too vague. > > Do you or Mika have access to an ia64 box to test. I don't. I'm not sure about Mika. > If not, can you suggest some way that I could exercise this code w/o the new > devices. Or at least reassure myself that all is benign in a system full of > old devices. There are two parts of the new code, one that's always executed, regardless of whether or not there are devices using the support provided by this series, and the other that's executed only for those devices. All depends on what's there in acpi_platform_device_ids[] (added by patch [5/5]), which is empty for now (Mika has a separate patch adding some IDs in there). The second part of the new code will only be run and platform device objects will only be created by it if there is at least one entry in acpi_platform_device_ids[] matching a device ID of an ACPI node in the BIOS. The BIOSes of currently available ia64 systems don't contain ACPI nodes whose IDs will match the IDs of the new devices (ie. the ones that are going to be added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to test that code as is (ie. without any new devices in the system). Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
> By "tested" I mean "run with some new devices that use the ACPI enumeration
> provided here, on x86". Sorry for being too vague.
Do you or Mika have access to an ia64 box to test. If not, can you suggest
some way that I could exercise this code w/o the new devices. Or at least
reassure myself that all is benign in a system full of old devices.
-Tony
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 08:03:34 PM Luck, Tony wrote: > On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: > > I wonder if the x86 and/or ia64 maintainers have any reservations? > > Can you elaborate on the "tested by mika" that you put into the 0/5 > message. Especially w.r.t. ia64. Compile tested? Boot tested? Ran with > some new device that uses the ACPI enumeration provided by this series? By "tested" I mean "run with some new devices that use the ACPI enumeration provided here, on x86". Sorry for being too vague. > Nothing in the concept or code scares me ... but I'd like to know that it > actually works :-) Sure. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: > I wonder if the x86 and/or ia64 maintainers have any reservations? Can you elaborate on the "tested by mika" that you put into the 0/5 message. Especially w.r.t. ia64. Compile tested? Boot tested? Ran with some new device that uses the ACPI enumeration provided by this series? Nothing in the concept or code scares me ... but I'd like to know that it actually works :-) -Tony
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 11:44:45 AM H. Peter Anvin wrote: > On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: > > > > Great, thanks! > > > > I wonder if the x86 and/or ia64 maintainers have any reservations? > > > > None here. > > Acked-by: H. Peter Anvin Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: Great, thanks! I wonder if the x86 and/or ia64 maintainers have any reservations? None here. Acked-by: H. Peter Anvin -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 09:24:07 AM Greg Kroah-Hartman wrote: > On Wed, Oct 31, 2012 at 10:38:29AM +0100, Rafael J. Wysocki wrote: > > From: Mika Westerberg > > > > With ACPI 5 we are starting to see devices that don't natively support > > discovery but can be enumerated with the help of the ACPI namespace. > > Typically, these devices can be represented in the Linux device driver > > model as platform devices or some serial bus devices, like SPI or I2C > > devices. > > > > Since we want to re-use existing drivers for those devices, we need a > > way for drivers to specify the ACPI IDs of supported devices, so that > > they can be matched against device nodes in the ACPI namespace. To > > this end, it is sufficient to add a pointer to an array of supported > > ACPI device IDs, that can be provided by the driver, to struct device. > > > > Moreover, things like ACPI power management need to have access to > > the ACPI handle of each supported device, because that handle is used > > to invoke AML methods associated with the corresponding ACPI device > > node. The ACPI handles of devices are now stored in the archdata > > member structure of struct device whose definition depends on the > > architecture and includes the ACPI handle only on x86 and ia64. Since > > the pointer to an array of supported ACPI IDs is added to struct > > device_driver in an architecture-independent way, it is logical to > > move the ACPI handle from archdata to struct device itself at the same > > time. This also makes code more straightforward in some places and > > follows the example of Device Trees that have a poiter to struct > > device_node in there too. > > > > This changeset is based on Mika Westerberg's work. > > > > Signed-off-by: Mika Westerberg > > Signed-off-by: Rafael J. Wysocki > > --- > > arch/ia64/include/asm/device.h |3 --- > > arch/x86/include/asm/device.h |3 --- > > drivers/acpi/glue.c| 14 ++ > > include/acpi/acpi_bus.h|2 +- > > include/linux/device.h |4 > > 5 files changed, 11 insertions(+), 15 deletions(-) > > The driver core pieces look fine to me: > > Acked-by: Greg Kroah-Hartman Great, thanks! I wonder if the x86 and/or ia64 maintainers have any reservations? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wed, Oct 31, 2012 at 10:38:29AM +0100, Rafael J. Wysocki wrote: > From: Mika Westerberg > > With ACPI 5 we are starting to see devices that don't natively support > discovery but can be enumerated with the help of the ACPI namespace. > Typically, these devices can be represented in the Linux device driver > model as platform devices or some serial bus devices, like SPI or I2C > devices. > > Since we want to re-use existing drivers for those devices, we need a > way for drivers to specify the ACPI IDs of supported devices, so that > they can be matched against device nodes in the ACPI namespace. To > this end, it is sufficient to add a pointer to an array of supported > ACPI device IDs, that can be provided by the driver, to struct device. > > Moreover, things like ACPI power management need to have access to > the ACPI handle of each supported device, because that handle is used > to invoke AML methods associated with the corresponding ACPI device > node. The ACPI handles of devices are now stored in the archdata > member structure of struct device whose definition depends on the > architecture and includes the ACPI handle only on x86 and ia64. Since > the pointer to an array of supported ACPI IDs is added to struct > device_driver in an architecture-independent way, it is logical to > move the ACPI handle from archdata to struct device itself at the same > time. This also makes code more straightforward in some places and > follows the example of Device Trees that have a poiter to struct > device_node in there too. > > This changeset is based on Mika Westerberg's work. > > Signed-off-by: Mika Westerberg > Signed-off-by: Rafael J. Wysocki > --- > arch/ia64/include/asm/device.h |3 --- > arch/x86/include/asm/device.h |3 --- > drivers/acpi/glue.c| 14 ++ > include/acpi/acpi_bus.h|2 +- > include/linux/device.h |4 > 5 files changed, 11 insertions(+), 15 deletions(-) The driver core pieces look fine to me: Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wed, Oct 31, 2012 at 10:38:29AM +0100, Rafael J. Wysocki wrote: From: Mika Westerberg mika.westerb...@linux.intel.com With ACPI 5 we are starting to see devices that don't natively support discovery but can be enumerated with the help of the ACPI namespace. Typically, these devices can be represented in the Linux device driver model as platform devices or some serial bus devices, like SPI or I2C devices. Since we want to re-use existing drivers for those devices, we need a way for drivers to specify the ACPI IDs of supported devices, so that they can be matched against device nodes in the ACPI namespace. To this end, it is sufficient to add a pointer to an array of supported ACPI device IDs, that can be provided by the driver, to struct device. Moreover, things like ACPI power management need to have access to the ACPI handle of each supported device, because that handle is used to invoke AML methods associated with the corresponding ACPI device node. The ACPI handles of devices are now stored in the archdata member structure of struct device whose definition depends on the architecture and includes the ACPI handle only on x86 and ia64. Since the pointer to an array of supported ACPI IDs is added to struct device_driver in an architecture-independent way, it is logical to move the ACPI handle from archdata to struct device itself at the same time. This also makes code more straightforward in some places and follows the example of Device Trees that have a poiter to struct device_node in there too. This changeset is based on Mika Westerberg's work. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- arch/ia64/include/asm/device.h |3 --- arch/x86/include/asm/device.h |3 --- drivers/acpi/glue.c| 14 ++ include/acpi/acpi_bus.h|2 +- include/linux/device.h |4 5 files changed, 11 insertions(+), 15 deletions(-) The driver core pieces look fine to me: Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 09:24:07 AM Greg Kroah-Hartman wrote: On Wed, Oct 31, 2012 at 10:38:29AM +0100, Rafael J. Wysocki wrote: From: Mika Westerberg mika.westerb...@linux.intel.com With ACPI 5 we are starting to see devices that don't natively support discovery but can be enumerated with the help of the ACPI namespace. Typically, these devices can be represented in the Linux device driver model as platform devices or some serial bus devices, like SPI or I2C devices. Since we want to re-use existing drivers for those devices, we need a way for drivers to specify the ACPI IDs of supported devices, so that they can be matched against device nodes in the ACPI namespace. To this end, it is sufficient to add a pointer to an array of supported ACPI device IDs, that can be provided by the driver, to struct device. Moreover, things like ACPI power management need to have access to the ACPI handle of each supported device, because that handle is used to invoke AML methods associated with the corresponding ACPI device node. The ACPI handles of devices are now stored in the archdata member structure of struct device whose definition depends on the architecture and includes the ACPI handle only on x86 and ia64. Since the pointer to an array of supported ACPI IDs is added to struct device_driver in an architecture-independent way, it is logical to move the ACPI handle from archdata to struct device itself at the same time. This also makes code more straightforward in some places and follows the example of Device Trees that have a poiter to struct device_node in there too. This changeset is based on Mika Westerberg's work. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- arch/ia64/include/asm/device.h |3 --- arch/x86/include/asm/device.h |3 --- drivers/acpi/glue.c| 14 ++ include/acpi/acpi_bus.h|2 +- include/linux/device.h |4 5 files changed, 11 insertions(+), 15 deletions(-) The driver core pieces look fine to me: Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Great, thanks! I wonder if the x86 and/or ia64 maintainers have any reservations? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: Great, thanks! I wonder if the x86 and/or ia64 maintainers have any reservations? None here. Acked-by: H. Peter Anvin h...@zytor.com -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 11:44:45 AM H. Peter Anvin wrote: On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: Great, thanks! I wonder if the x86 and/or ia64 maintainers have any reservations? None here. Acked-by: H. Peter Anvin h...@zytor.com Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: I wonder if the x86 and/or ia64 maintainers have any reservations? Can you elaborate on the tested by mika that you put into the 0/5 message. Especially w.r.t. ia64. Compile tested? Boot tested? Ran with some new device that uses the ACPI enumeration provided by this series? Nothing in the concept or code scares me ... but I'd like to know that it actually works :-) -Tony
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 08:03:34 PM Luck, Tony wrote: On 10/31/2012 11:42 AM, Rafael J. Wysocki wrote: I wonder if the x86 and/or ia64 maintainers have any reservations? Can you elaborate on the tested by mika that you put into the 0/5 message. Especially w.r.t. ia64. Compile tested? Boot tested? Ran with some new device that uses the ACPI enumeration provided by this series? By tested I mean run with some new devices that use the ACPI enumeration provided here, on x86. Sorry for being too vague. Nothing in the concept or code scares me ... but I'd like to know that it actually works :-) Sure. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
By tested I mean run with some new devices that use the ACPI enumeration
provided here, on x86. Sorry for being too vague.
Do you or Mika have access to an ia64 box to test. If not, can you suggest
some way that I could exercise this code w/o the new devices. Or at least
reassure myself that all is benign in a system full of old devices.
-Tony
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: By tested I mean run with some new devices that use the ACPI enumeration provided here, on x86. Sorry for being too vague. Do you or Mika have access to an ia64 box to test. I don't. I'm not sure about Mika. If not, can you suggest some way that I could exercise this code w/o the new devices. Or at least reassure myself that all is benign in a system full of old devices. There are two parts of the new code, one that's always executed, regardless of whether or not there are devices using the support provided by this series, and the other that's executed only for those devices. All depends on what's there in acpi_platform_device_ids[] (added by patch [5/5]), which is empty for now (Mika has a separate patch adding some IDs in there). The second part of the new code will only be run and platform device objects will only be created by it if there is at least one entry in acpi_platform_device_ids[] matching a device ID of an ACPI node in the BIOS. The BIOSes of currently available ia64 systems don't contain ACPI nodes whose IDs will match the IDs of the new devices (ie. the ones that are going to be added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to test that code as is (ie. without any new devices in the system). Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wed, Oct 31, 2012 at 10:06:00PM +0100, Rafael J. Wysocki wrote: On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: By tested I mean run with some new devices that use the ACPI enumeration provided here, on x86. Sorry for being too vague. Do you or Mika have access to an ia64 box to test. I don't. I'm not sure about Mika. I also don't have access to any ia64 machine. As Rafael said, I tested this on x86 machine only. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
The BIOSes of currently available ia64 systems don't contain ACPI nodes whose IDs will match the IDs of the new devices (ie. the ones that are going to be added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to test that code as is (ie. without any new devices in the system). Ok - built cleanly on ia64. Boots too. Just one new console message: ACPI: bus type platform registered that seems pretty harmless. Acked-by: Tony Luck tony.l...@intel.com
Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types
On Wednesday, October 31, 2012 09:36:36 PM Luck, Tony wrote: The BIOSes of currently available ia64 systems don't contain ACPI nodes whose IDs will match the IDs of the new devices (ie. the ones that are going to be added to acpi_platform_device_ids[]), so for ia64 it should be sufficient to test that code as is (ie. without any new devices in the system). Ok - built cleanly on ia64. Boots too. Just one new console message: ACPI: bus type platform registered that seems pretty harmless. Acked-by: Tony Luck tony.l...@intel.com Thanks a lot! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
