Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, Dec 03, 2007 at 04:00:11PM +, Ralf Baechle wrote: > On Mon, Dec 03, 2007 at 03:15:29PM +, David Howells wrote: > > > > - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway > > > scheduled for removal in 2.6.25 > > > > I'm told (by Ralf) that removing this support will

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, Dec 03, 2007 at 03:15:29PM +, David Howells wrote: > > - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway > > scheduled for removal in 2.6.25 > > I'm told (by Ralf) that removing this support will break Castle Wolfenstein or > something like that. > > So unless you want

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk <[EMAIL PROTECTED]> wrote: > - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway > scheduled for removal in 2.6.25 I'm told (by Ralf) that removing this support will break Castle Wolfenstein or something like that. So unless you want hordes of rampaging MIPS users

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk [EMAIL PROTECTED] wrote: - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway scheduled for removal in 2.6.25 I'm told (by Ralf) that removing this support will break Castle Wolfenstein or something like that. So unless you want hordes of rampaging MIPS users breaking

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, Dec 03, 2007 at 03:15:29PM +, David Howells wrote: - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway scheduled for removal in 2.6.25 I'm told (by Ralf) that removing this support will break Castle Wolfenstein or something like that. So unless you want hordes

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, Dec 03, 2007 at 04:00:11PM +, Ralf Baechle wrote: On Mon, Dec 03, 2007 at 03:15:29PM +, David Howells wrote: - it adds #ifdef's in fs/binfmt_elf.c for code that is anyway scheduled for removal in 2.6.25 I'm told (by Ralf) that removing this support will break Castle

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 2007-11-13 at 14:40 -0600, Matt Mackall wrote: > On Tue, Nov 13, 2007 at 01:46:46PM +0100, Peter Zijlstra wrote: > > > > On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: > > > On Tue, 13 Nov 2007 10:57:31 + David Howells <[EMAIL PROTECTED]> > > > wrote: > > > > > > > SL Baur

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, Nov 13, 2007 at 01:46:46PM +0100, Peter Zijlstra wrote: > > On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: > > On Tue, 13 Nov 2007 10:57:31 + David Howells <[EMAIL PROTECTED]> wrote: > > > > > SL Baur <[EMAIL PROTECTED]> wrote: > > > > > > > Please take the emacsism out of

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: > On Tue, 13 Nov 2007 10:57:31 + David Howells <[EMAIL PROTECTED]> wrote: > > > SL Baur <[EMAIL PROTECTED]> wrote: > > > > > Please take the emacsism out of the file as it bothers Andrew and others. > > > > I thought Andrew said it

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 13 Nov 2007 10:57:31 + David Howells <[EMAIL PROTECTED]> wrote: > SL Baur <[EMAIL PROTECTED]> wrote: > > > Please take the emacsism out of the file as it bothers Andrew and others. > > I thought Andrew said it didn't bother him. I assume he was curious. > Well it's just one line

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

SL Baur <[EMAIL PROTECTED]> wrote: > Please take the emacsism out of the file as it bothers Andrew and others. I thought Andrew said it didn't bother him. I assume he was curious. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

SL Baur [EMAIL PROTECTED] wrote: Please take the emacsism out of the file as it bothers Andrew and others. I thought Andrew said it didn't bother him. I assume he was curious. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 13 Nov 2007 10:57:31 + David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED] wrote: Please take the emacsism out of the file as it bothers Andrew and others. I thought Andrew said it didn't bother him. I assume he was curious. Well it's just one line - hardly a

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: On Tue, 13 Nov 2007 10:57:31 + David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED] wrote: Please take the emacsism out of the file as it bothers Andrew and others. I thought Andrew said it didn't bother him.

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, Nov 13, 2007 at 01:46:46PM +0100, Peter Zijlstra wrote: On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: On Tue, 13 Nov 2007 10:57:31 + David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED] wrote: Please take the emacsism out of the file as it

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Tue, 2007-11-13 at 14:40 -0600, Matt Mackall wrote: On Tue, Nov 13, 2007 at 01:46:46PM +0100, Peter Zijlstra wrote: On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: On Tue, 13 Nov 2007 10:57:31 + David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED]

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On 11/12/07, David Howells <[EMAIL PROTECTED]> wrote: > SL Baur <[EMAIL PROTECTED]> wrote: > > > (push '("/Kbuild" . makefile-mode) auto-mode-alist) > > Does that work for Kbuild.asm too, more to the point? Of course. It works for any filename beginning with the string "Kbuild". Major mode

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

SL Baur <[EMAIL PROTECTED]> wrote: > (push '("/Kbuild" . makefile-mode) auto-mode-alist) Does that work for Kbuild.asm too, more to the point? David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On 11/12/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 12 Nov 2007 15:34:40 + David Howells <[EMAIL PROTECTED]> wrote: > > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > +# -*- makefile -*- > > > > > > what's that? > > > > Ah... That tells emacs that it's a makefile. In

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, 12 Nov 2007 15:34:40 + David Howells <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > +# -*- makefile -*- > > > > what's that? > > Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its > an Assembly file and not a makefile. This

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Andrew Morton <[EMAIL PROTECTED]> wrote: > > +# -*- makefile -*- > > what's that? Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its an Assembly file and not a makefile. This causes it to attempt to do automatic indentation on it. Do you want me to drop these

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Andrew Morton [EMAIL PROTECTED] wrote: +# -*- makefile -*- what's that? Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its an Assembly file and not a makefile. This causes it to attempt to do automatic indentation on it. Do you want me to drop these annotation

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Mon, 12 Nov 2007 15:34:40 + David Howells [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: +# -*- makefile -*- what's that? Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its an Assembly file and not a makefile. This causes it to

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On 11/12/07, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 12 Nov 2007 15:34:40 + David Howells [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: +# -*- makefile -*- what's that? Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

SL Baur [EMAIL PROTECTED] wrote: (push '(/Kbuild . makefile-mode) auto-mode-alist) Does that work for Kbuild.asm too, more to the point? David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On 11/12/07, David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED] wrote: (push '(/Kbuild . makefile-mode) auto-mode-alist) Does that work for Kbuild.asm too, more to the point? Of course. It works for any filename beginning with the string Kbuild. Major mode rules are on a

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Andi Kleen <[EMAIL PROTECTED]> wrote: > One problem is that EXPORT_SYMBOL always creates a reference to the function > even when nothing uses it. Exactly. This function is for use in something that can be compiled as a module, therefore this sort of thing is academic - unless we take away the

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 04:46:26PM +0100, Andi Kleen wrote: > > > My thoughts go more into the direction that we have hundreds of similar > > cases where e.g. a VFS function might currently only by used by OCFS2 > > and therefore be dead code for most users, and the only maintainable > > solution

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

> My thoughts go more into the direction that we have hundreds of similar > cases where e.g. a VFS function might currently only by used by OCFS2 > and therefore be dead code for most users, and the only maintainable > solution will be to solve these at the compiler and/or linker level.

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 03:03:56PM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > It's BTW not an improvement that you do not only rename them but change > > such big functions to static inline functions in header files. > > I'm not sure what you meant by that. > >

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk <[EMAIL PROTECTED]> wrote: > It's BTW not an improvement that you do not only rename them but change > such big functions to static inline functions in header files. I'm not sure what you meant by that. Renaming them indicates more clearly that their only purpose is for A.OUT

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 01:59:29PM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > - too many cleanups lumped into one patch > > Perhaps, but unfortunately a lot of them are related and required for a > compilable patch. I can probably split it up 4 ways if you really

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk <[EMAIL PROTECTED]> wrote: > - too many cleanups lumped into one patch Perhaps, but unfortunately a lot of them are related and required for a compilable patch. I can probably split it up 4 ways if you really want me to, in order: (1) Move STACK_TOP[_MAX]. (2) Rename

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Fri, Nov 09, 2007 at 03:34:37PM +, David Howells wrote: > Suppress A.OUT library support if CONFIG_BINFMT_AOUT is not set. > > Not all architectures support the A.OUT binfmt, so the ELF binfmt should not > be permitted to go looking for A.OUT libraries to load in such a case. Not > only

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Fri, Nov 09, 2007 at 03:34:37PM +, David Howells wrote: Suppress A.OUT library support if CONFIG_BINFMT_AOUT is not set. Not all architectures support the A.OUT binfmt, so the ELF binfmt should not be permitted to go looking for A.OUT libraries to load in such a case. Not only that,

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk [EMAIL PROTECTED] wrote: - too many cleanups lumped into one patch Perhaps, but unfortunately a lot of them are related and required for a compilable patch. I can probably split it up 4 ways if you really want me to, in order: (1) Move STACK_TOP[_MAX]. (2) Rename dump_thread()

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 01:59:29PM +, David Howells wrote: Adrian Bunk [EMAIL PROTECTED] wrote: - too many cleanups lumped into one patch Perhaps, but unfortunately a lot of them are related and required for a compilable patch. I can probably split it up 4 ways if you really want me

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Adrian Bunk [EMAIL PROTECTED] wrote: It's BTW not an improvement that you do not only rename them but change such big functions to static inline functions in header files. I'm not sure what you meant by that. Renaming them indicates more clearly that their only purpose is for A.OUT support.

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 03:03:56PM +, David Howells wrote: Adrian Bunk [EMAIL PROTECTED] wrote: It's BTW not an improvement that you do not only rename them but change such big functions to static inline functions in header files. I'm not sure what you meant by that. Renaming

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

My thoughts go more into the direction that we have hundreds of similar cases where e.g. a VFS function might currently only by used by OCFS2 and therefore be dead code for most users, and the only maintainable solution will be to solve these at the compiler and/or linker level.

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Sun, Nov 11, 2007 at 04:46:26PM +0100, Andi Kleen wrote: My thoughts go more into the direction that we have hundreds of similar cases where e.g. a VFS function might currently only by used by OCFS2 and therefore be dead code for most users, and the only maintainable solution will be

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

Andi Kleen [EMAIL PROTECTED] wrote: One problem is that EXPORT_SYMBOL always creates a reference to the function even when nothing uses it. Exactly. This function is for use in something that can be compiled as a module, therefore this sort of thing is academic - unless we take away the

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Fri, 09 Nov 2007 15:34:37 + David Howells <[EMAIL PROTECTED]> wrote: > --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -1,3 +1,4 @@ > +# -*- makefile -*- what's that? > header-y += byteorder/ > header-y += dvb/ > header-y += hdlc/ > @@ -17,7 +18,9 @@ header-y += usb/ >

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

On Fri, 09 Nov 2007 15:34:37 + David Howells [EMAIL PROTECTED] wrote: --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -1,3 +1,4 @@ +# -*- makefile -*- what's that? header-y += byteorder/ header-y += dvb/ header-y += hdlc/ @@ -17,7 +18,9 @@ header-y += usb/ header-y