Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()

2020-09-12 Thread Linus Walleij 
On Fri, Aug 28, 2020 at 8:17 PM Bartosz Golaszewski
 wrote:

> Queued the entire series with all the tags, thanks!

Oh you already queued them, I'll drop them from my tree.

Thanks!
Linus Walleij

Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()

2020-08-28 Thread Bartosz Golaszewski 
On Thu, Aug 27, 2020 at 10:08 PM Krzysztof Kozlowski  wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/gpio/gpio-bcm-kona.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index cf3687a7925f..1e6b427f2c4a 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device 
> *pdev)
> dev_err(dev, "Couldn't determine # GPIO banks\n");
> return -ENOENT;
> } else if (ret < 0) {
> -   if (ret != -EPROBE_DEFER)
> -   dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
> -   ERR_PTR(ret));
> -   return ret;
> +   return dev_err_probe(dev, ret, "Couldn't determine GPIO 
> banks\n");
> }
> kona_gpio->num_bank = ret;
>
> --
> 2.17.1
>

Queued the entire series with all the tags, thanks!

Bartosz

Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()

2020-08-28 Thread Florian Fainelli 
On 8/27/20 1:08 PM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
> 
> Signed-off-by: Krzysztof Kozlowski 

Acked-by: Florian Fainelli 
-- 
Florian

Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()

2020-08-28 Thread Andy Shevchenko 
On Thu, Aug 27, 2020 at 11:09 PM Krzysztof Kozlowski  wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
>

I believe you are doing this right (after we have discussed previous
series and approaches).
Reviewed-by: Andy Shevchenko 
for entire series (Linus!)

> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/gpio/gpio-bcm-kona.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index cf3687a7925f..1e6b427f2c4a 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device 
> *pdev)
> dev_err(dev, "Couldn't determine # GPIO banks\n");
> return -ENOENT;
> } else if (ret < 0) {
> -   if (ret != -EPROBE_DEFER)
> -   dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
> -   ERR_PTR(ret));
> -   return ret;
> +   return dev_err_probe(dev, ret, "Couldn't determine GPIO 
> banks\n");
> }
> kona_gpio->num_bank = ret;
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko