Re: [PATCH 1/9] Staging: lustre: dir: Replace function calls

2015-11-09 Thread Dan Carpenter
If we ever need the wrapper, we can add it again. These wrappers only hurt readability because they trick you into thinking there is some reference counting or something but it's just an ordinary kfree(). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/9] Staging: lustre: dir: Replace function calls

2015-11-09 Thread Drokin, Oleg
On Nov 7, 2015, at 2:41 AM, Shivani Bhardwaj wrote: > Replace the calls of the function ll_finish_md_op_data() with the > standard function kfree(). For functions like this that have meaningflul name and also might include additional logic (even though they don't now), does it make sense to do

Re: [PATCH 1/9] Staging: lustre: dir: Replace function calls

2015-11-09 Thread Dan Carpenter
If we ever need the wrapper, we can add it again. These wrappers only hurt readability because they trick you into thinking there is some reference counting or something but it's just an ordinary kfree(). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/9] Staging: lustre: dir: Replace function calls

2015-11-09 Thread Drokin, Oleg
On Nov 7, 2015, at 2:41 AM, Shivani Bhardwaj wrote: > Replace the calls of the function ll_finish_md_op_data() with the > standard function kfree(). For functions like this that have meaningflul name and also might include additional logic (even though they don't now), does it make sense to do