Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Ulf Magnusson]

On Mon, Feb 19, 2018 at 4:48 PM, Rob Herring  wrote:
> On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
>> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
>> GENERIC_IO option"), but HAS_IOMEM still selects it.
>>
>> Remove the select of GENERIC_IO from HAS_IOMEM.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson 
>> ---
>>  lib/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>
> Who do you intend to apply this because people keep sending the same fix?
>
> Rob

I didn't have a particular tree in mind. I imagined people would pick
up patches into the trees where they make the most sense.

I just turned it into a patchset to keep track of it easier myself.
Looks like that might have caused some confusion in retrospect.

Cheers,
Ulf

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Ulf Magnusson]

On Mon, Feb 19, 2018 at 4:48 PM, Rob Herring  wrote:
> On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
>> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
>> GENERIC_IO option"), but HAS_IOMEM still selects it.
>>
>> Remove the select of GENERIC_IO from HAS_IOMEM.
>>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson 
>> ---
>>  lib/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>
> Who do you intend to apply this because people keep sending the same fix?
>
> Rob

I didn't have a particular tree in mind. I imagined people would pick
up patches into the trees where they make the most sense.

I just turned it into a patchset to keep track of it easier myself.
Looks like that might have caused some confusion in retrospect.

Cheers,
Ulf

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Rob Herring]

On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
> GENERIC_IO option"), but HAS_IOMEM still selects it.
>
> Remove the select of GENERIC_IO from HAS_IOMEM.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson 
> ---
>  lib/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Who do you intend to apply this because people keep sending the same fix?

Rob

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Rob Herring]

On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
> GENERIC_IO option"), but HAS_IOMEM still selects it.
>
> Remove the select of GENERIC_IO from HAS_IOMEM.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson 
> ---
>  lib/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Who do you intend to apply this because people keep sending the same fix?

Rob

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Robin Murphy]

On 05/02/18 01:21, Ulf Magnusson wrote:

GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
GENERIC_IO option"), but HAS_IOMEM still selects it.

Remove the select of GENERIC_IO from HAS_IOMEM.

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.


Since I also stumbled over this and tried to fix it,

Acked-by: Robin Murphy 


Signed-off-by: Ulf Magnusson 
---
  lib/Kconfig | 1 -
  1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index e96089499371..8ce8bcad6eff 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -396,7 +396,6 @@ config ASSOCIATIVE_ARRAY
  config HAS_IOMEM
bool
depends on !NO_IOMEM
-   select GENERIC_IO
default y
  
  config HAS_IOPORT_MAP

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Robin Murphy]

On 05/02/18 01:21, Ulf Magnusson wrote:

GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
GENERIC_IO option"), but HAS_IOMEM still selects it.

Remove the select of GENERIC_IO from HAS_IOMEM.

Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.


Since I also stumbled over this and tried to fix it,

Acked-by: Robin Murphy 


Signed-off-by: Ulf Magnusson 
---
  lib/Kconfig | 1 -
  1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig b/lib/Kconfig
index e96089499371..8ce8bcad6eff 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -396,7 +396,6 @@ config ASSOCIATIVE_ARRAY
  config HAS_IOMEM
bool
depends on !NO_IOMEM
-   select GENERIC_IO
default y
  
  config HAS_IOPORT_MAP

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Rob Herring]

On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
> GENERIC_IO option"), but HAS_IOMEM still selects it.
>
> Remove the select of GENERIC_IO from HAS_IOMEM.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson 
> ---
>  lib/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

There was another fix[1] for this but it seems to have gotten lost.

Acked-by: Rob Herring 

Rob

[1] https://lkml.org/lkml/2018/1/17/924

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

[Rob Herring]

On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson  wrote:
> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off
> GENERIC_IO option"), but HAS_IOMEM still selects it.
>
> Remove the select of GENERIC_IO from HAS_IOMEM.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson 
> ---
>  lib/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

There was another fix[1] for this but it seems to have gotten lost.

Acked-by: Rob Herring 

Rob

[1] https://lkml.org/lkml/2018/1/17/924