Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-14 Thread Jiri Olsa
On Tue, Jan 14, 2014 at 08:55:50AM +0900, Namhyung Kim wrote: > Hi Jiri, > > Thanks for reminding me. :) > > On Thu, 9 Jan 2014 19:06:28 +0100, Jiri Olsa wrote: > > On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: > > [SNIP] > >> + /* > >> + * Check if there's duplicate entries

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-14 Thread Jiri Olsa
On Tue, Jan 14, 2014 at 08:55:50AM +0900, Namhyung Kim wrote: Hi Jiri, Thanks for reminding me. :) On Thu, 9 Jan 2014 19:06:28 +0100, Jiri Olsa wrote: On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: [SNIP] + /* + * Check if there's duplicate entries in the

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-13 Thread Namhyung Kim
Hi Jiri, Thanks for reminding me. :) On Thu, 9 Jan 2014 19:06:28 +0100, Jiri Olsa wrote: > On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: [SNIP] >> +/* >> + * Check if there's duplicate entries in the callchain. >> + * It's possible that it has cycles or recursive

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-13 Thread Namhyung Kim
Hi Jiri, On Sat, 11 Jan 2014 17:02:54 +0100, Jiri Olsa wrote: > On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: >> It is possble that a callchain has cycles or recursive calls. In that >> case it'll end up having entries more than 100% overhead in the >> output. In order to

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-13 Thread Namhyung Kim
Hi Jiri, On Sat, 11 Jan 2014 17:02:54 +0100, Jiri Olsa wrote: On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: It is possble that a callchain has cycles or recursive calls. In that case it'll end up having entries more than 100% overhead in the output. In order to prevent such

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-13 Thread Namhyung Kim
Hi Jiri, Thanks for reminding me. :) On Thu, 9 Jan 2014 19:06:28 +0100, Jiri Olsa wrote: On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: [SNIP] +/* + * Check if there's duplicate entries in the callchain. + * It's possible that it has cycles or recursive calls. +

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-11 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: > It is possble that a callchain has cycles or recursive calls. In that > case it'll end up having entries more than 100% overhead in the > output. In order to prevent such entries, cache each callchain node > and skip if same entry

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-11 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: It is possble that a callchain has cycles or recursive calls. In that case it'll end up having entries more than 100% overhead in the output. In order to prevent such entries, cache each callchain node and skip if same entry

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-09 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: SNIP > goto out; > } > > - if (al->map->groups == >machine->kmaps) { > - if (machine__is_host(iter->machine)) { > + if (al->map->groups == >machine->kmaps) { > + if

Re: [PATCH 10/28] perf report: Cache cumulative callchains

2014-01-09 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:15PM +0900, Namhyung Kim wrote: SNIP goto out; } - if (al-map-groups == iter-machine-kmaps) { - if (machine__is_host(iter-machine)) { + if (al-map-groups == al-machine-kmaps) { + if