Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-25 Thread Michal Hocko
On Sun 25-06-17 08:14:13, Wei Yang wrote: > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: > >From: Michal Hocko > > > [...] > >+void move_pfn_range_to_zone(struct zone *zone, > >+unsigned long start_pfn, unsigned long nr_pages) > >+{ > >+struct

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-25 Thread Michal Hocko
On Sun 25-06-17 08:14:13, Wei Yang wrote: > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: > >From: Michal Hocko > > > [...] > >+void move_pfn_range_to_zone(struct zone *zone, > >+unsigned long start_pfn, unsigned long nr_pages) > >+{ > >+struct pglist_data *pgdat =

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-24 Thread Wei Yang
On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > [...] >+void move_pfn_range_to_zone(struct zone *zone, >+ unsigned long start_pfn, unsigned long nr_pages) >+{ >+ struct pglist_data *pgdat = zone->zone_pgdat; >+ int nid =

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-24 Thread Wei Yang
On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > [...] >+void move_pfn_range_to_zone(struct zone *zone, >+ unsigned long start_pfn, unsigned long nr_pages) >+{ >+ struct pglist_data *pgdat = zone->zone_pgdat; >+ int nid = pgdat->node_id;

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Wei Yang
On Fri, Jun 16, 2017 at 10:45:55AM +0200, Michal Hocko wrote: >On Fri 16-06-17 16:11:42, Wei Yang wrote: >> Well, I love this patch a lot. We don't need to put the hotadd memory in one >> zone and move it to another. This looks great! >> >> On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Wei Yang
On Fri, Jun 16, 2017 at 10:45:55AM +0200, Michal Hocko wrote: >On Fri 16-06-17 16:11:42, Wei Yang wrote: >> Well, I love this patch a lot. We don't need to put the hotadd memory in one >> zone and move it to another. This looks great! >> >> On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Michal Hocko
On Fri 16-06-17 16:11:42, Wei Yang wrote: > Well, I love this patch a lot. We don't need to put the hotadd memory in one > zone and move it to another. This looks great! > > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: > >From: Michal Hocko > > > [...] > + >

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Michal Hocko
On Fri 16-06-17 16:11:42, Wei Yang wrote: > Well, I love this patch a lot. We don't need to put the hotadd memory in one > zone and move it to another. This looks great! > > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: > >From: Michal Hocko > > > [...] > + > >+void

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Wei Yang
Well, I love this patch a lot. We don't need to put the hotadd memory in one zone and move it to another. This looks great! On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > [...] + >+void move_pfn_range_to_zone(struct zone *zone, >+

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Wei Yang
Well, I love this patch a lot. We don't need to put the hotadd memory in one zone and move it to another. This looks great! On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > [...] + >+void move_pfn_range_to_zone(struct zone *zone, >+ unsigned long

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Michal Hocko
[Please try to trim the context you are replying to] On Fri 16-06-17 12:20:58, Wei Yang wrote: > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: [...] > > /* > >+ * Return true if [start_pfn, start_pfn + nr_pages) range has a non-empty > >+ * intersection with the given zone > >+ */

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-16 Thread Michal Hocko
[Please try to trim the context you are replying to] On Fri 16-06-17 12:20:58, Wei Yang wrote: > On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: [...] > > /* > >+ * Return true if [start_pfn, start_pfn + nr_pages) range has a non-empty > >+ * intersection with the given zone > >+ */

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-15 Thread Wei Yang
On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > >The current memory hotplug implementation relies on having all the >struct pages associate with a zone/node during the physical hotplug phase

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-06-15 Thread Wei Yang
On Mon, May 15, 2017 at 10:58:24AM +0200, Michal Hocko wrote: >From: Michal Hocko > >The current memory hotplug implementation relies on having all the >struct pages associate with a zone/node during the physical hotplug phase >(arch_add_memory->__add_pages->__add_section->__add_zone). In the

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-05-19 Thread Vlastimil Babka
On 05/15/2017 10:58 AM, Michal Hocko wrote: > From: Michal Hocko > > The current memory hotplug implementation relies on having all the > struct pages associate with a zone/node during the physical hotplug phase > (arch_add_memory->__add_pages->__add_section->__add_zone). In the

Re: [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online

2017-05-19 Thread Vlastimil Babka
On 05/15/2017 10:58 AM, Michal Hocko wrote: > From: Michal Hocko > > The current memory hotplug implementation relies on having all the > struct pages associate with a zone/node during the physical hotplug phase > (arch_add_memory->__add_pages->__add_section->__add_zone). In the vast > majority