Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-11 Thread Kent Overstreet
On Fri, Oct 11, 2013 at 05:16:42PM -0400, Mike Snitzer wrote: > On Fri, Oct 11 2013 at 12:13am -0400, > Kent Overstreet wrote: > > > On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: > > > > > > Please fold this fix into your for-jens branch, thanks. (Could be that > > > by the

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-11 Thread Mike Snitzer
On Fri, Oct 11 2013 at 12:13am -0400, Kent Overstreet wrote: > On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: > > > > Please fold this fix into your for-jens branch, thanks. (Could be that > > by the time Jens takes your immutable biovec changes we'll need to > > rebase but at

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-11 Thread Mike Snitzer
On Fri, Oct 11 2013 at 12:13am -0400, Kent Overstreet k...@daterainc.com wrote: On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: Please fold this fix into your for-jens branch, thanks. (Could be that by the time Jens takes your immutable biovec changes we'll need to rebase

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-11 Thread Kent Overstreet
On Fri, Oct 11, 2013 at 05:16:42PM -0400, Mike Snitzer wrote: On Fri, Oct 11 2013 at 12:13am -0400, Kent Overstreet k...@daterainc.com wrote: On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: Please fold this fix into your for-jens branch, thanks. (Could be that by the

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-10 Thread Kent Overstreet
On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: > On Fri, Oct 04 2013 at 1:07pm -0400, > Mike Snitzer wrote: > > > With your latest fix I was able to create a thin device and format with > > XFS. Unfortunately, when I tried to run the thinp-test-suite the very > > first

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-10 Thread Kent Overstreet
On Sun, Oct 06, 2013 at 08:14:10PM -0400, Mike Snitzer wrote: On Fri, Oct 04 2013 at 1:07pm -0400, Mike Snitzer snit...@redhat.com wrote: With your latest fix I was able to create a thin device and format with XFS. Unfortunately, when I tried to run the thinp-test-suite the very first

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-06 Thread Mike Snitzer
On Fri, Oct 04 2013 at 1:07pm -0400, Mike Snitzer wrote: > With your latest fix I was able to create a thin device and format with > XFS. Unfortunately, when I tried to run the thinp-test-suite the very > first BasicTests test (test_dd_benchmark) fails -- need to look closer > but it would

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-06 Thread Mike Snitzer
On Fri, Oct 04 2013 at 1:07pm -0400, Mike Snitzer snit...@redhat.com wrote: With your latest fix I was able to create a thin device and format with XFS. Unfortunately, when I tried to run the thinp-test-suite the very first BasicTests test (test_dd_benchmark) fails -- need to look closer

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-04 Thread Mike Snitzer
On Thu, Oct 03 2013 at 6:50pm -0400, Mike Snitzer wrote: > On Thu, Oct 03 2013 at 5:45pm -0400, > Kent Overstreet wrote: > > > On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: > > > Great, thanks for finding this, I'll test and review the code further. > > > > Cool - let me

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-04 Thread Mike Snitzer
On Thu, Oct 03 2013 at 6:50pm -0400, Mike Snitzer snit...@redhat.com wrote: On Thu, Oct 03 2013 at 5:45pm -0400, Kent Overstreet k...@daterainc.com wrote: On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: Great, thanks for finding this, I'll test and review the code

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-03 Thread Mike Snitzer
On Thu, Oct 03 2013 at 5:45pm -0400, Kent Overstreet wrote: > On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: > > Great, thanks for finding this, I'll test and review the code further. > > Cool - let me know if you find anything else (how thoroughly do you > think you've tested

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-03 Thread Kent Overstreet
On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: > Great, thanks for finding this, I'll test and review the code further. Cool - let me know if you find anything else (how thoroughly do you think you've tested it so far?) -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-03 Thread Kent Overstreet
On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: Great, thanks for finding this, I'll test and review the code further. Cool - let me know if you find anything else (how thoroughly do you think you've tested it so far?) -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-03 Thread Mike Snitzer
On Thu, Oct 03 2013 at 5:45pm -0400, Kent Overstreet k...@daterainc.com wrote: On Wed, Oct 02, 2013 at 11:23:21PM -0400, Mike Snitzer wrote: Great, thanks for finding this, I'll test and review the code further. Cool - let me know if you find anything else (how thoroughly do you think

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-02 Thread Mike Snitzer
On Wed, Oct 02 2013 at 11:17pm -0400, Kent Overstreet wrote: > On Sat, Sep 28, 2013 at 12:59:09AM -0400, Mike Snitzer wrote: > > Hey Kent, > > > > I haven't been able to pinpoint the issue yet, but using your for-jens > > branch, if I create a dm-thin volume with this lvm command: > > lvcreate

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-02 Thread Kent Overstreet
On Sat, Sep 28, 2013 at 12:59:09AM -0400, Mike Snitzer wrote: > Hey Kent, > > I haven't been able to pinpoint the issue yet, but using your for-jens > branch, if I create a dm-thin volume with this lvm command: > lvcreate -L20G -V20G -T vg/pool --name thinlv > > and try to format /dev/vg/thinlv

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-02 Thread Kent Overstreet
On Sat, Sep 28, 2013 at 12:59:09AM -0400, Mike Snitzer wrote: Hey Kent, I haven't been able to pinpoint the issue yet, but using your for-jens branch, if I create a dm-thin volume with this lvm command: lvcreate -L20G -V20G -T vg/pool --name thinlv and try to format /dev/vg/thinlv with

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-10-02 Thread Mike Snitzer
On Wed, Oct 02 2013 at 11:17pm -0400, Kent Overstreet k...@daterainc.com wrote: On Sat, Sep 28, 2013 at 12:59:09AM -0400, Mike Snitzer wrote: Hey Kent, I haven't been able to pinpoint the issue yet, but using your for-jens branch, if I create a dm-thin volume with this lvm command:

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-09-27 Thread Mike Snitzer
On Wed, Aug 07 2013 at 5:54pm -0400, Kent Overstreet wrote: > We need to convert the dm code to the new bvec_iter primitives which > respect bi_bvec_done; they also allow us to drastically simplify dm's > bio splitting code. > > Also kill bio_sector_offset(), dm was the only user and it

Re: [PATCH 16/22] dm: Refactor for new bio cloning/splitting

2013-09-27 Thread Mike Snitzer
On Wed, Aug 07 2013 at 5:54pm -0400, Kent Overstreet k...@daterainc.com wrote: We need to convert the dm code to the new bvec_iter primitives which respect bi_bvec_done; they also allow us to drastically simplify dm's bio splitting code. Also kill bio_sector_offset(), dm was the only user