Re: [PATCH 2/2] arm-ccn: perf: Prevent module unload while PMU is in use
On Fri, Nov 03, 2017 at 11:45:18AM +, Suzuki K Poulose wrote: > When the PMU driver is built as a module, the perf expects the > pmu->module to be valid, so that the driver is prevented from > being unloaded while it is in use. Fix the CCN pmu driver to > fill in this field. > > Fixes: commit a33b0daab73a0 ("bus: ARM CCN PMU driver") > Cc: Pawel Moll> Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Suzuki K Poulose With Will's nit on the Fixes tag cleaned up: Acked-by: Mark Rutland Mark. > --- > drivers/bus/arm-ccn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c > index e8c6946fed9d..3063f5312397 100644 > --- a/drivers/bus/arm-ccn.c > +++ b/drivers/bus/arm-ccn.c > @@ -1276,6 +1276,7 @@ static int arm_ccn_pmu_init(struct arm_ccn *ccn) > > /* Perf driver registration */ > ccn->dt.pmu = (struct pmu) { > + .module = THIS_MODULE, > .attr_groups = arm_ccn_pmu_attr_groups, > .task_ctx_nr = perf_invalid_context, > .event_init = arm_ccn_pmu_event_init, > -- > 2.13.6 >
Re: [PATCH 2/2] arm-ccn: perf: Prevent module unload while PMU is in use
On Fri, Nov 03, 2017 at 11:45:18AM +, Suzuki K Poulose wrote: > When the PMU driver is built as a module, the perf expects the > pmu->module to be valid, so that the driver is prevented from > being unloaded while it is in use. Fix the CCN pmu driver to > fill in this field. > > Fixes: commit a33b0daab73a0 ("bus: ARM CCN PMU driver") > Cc: Pawel Moll > Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Suzuki K Poulose With Will's nit on the Fixes tag cleaned up: Acked-by: Mark Rutland Mark. > --- > drivers/bus/arm-ccn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c > index e8c6946fed9d..3063f5312397 100644 > --- a/drivers/bus/arm-ccn.c > +++ b/drivers/bus/arm-ccn.c > @@ -1276,6 +1276,7 @@ static int arm_ccn_pmu_init(struct arm_ccn *ccn) > > /* Perf driver registration */ > ccn->dt.pmu = (struct pmu) { > + .module = THIS_MODULE, > .attr_groups = arm_ccn_pmu_attr_groups, > .task_ctx_nr = perf_invalid_context, > .event_init = arm_ccn_pmu_event_init, > -- > 2.13.6 >
Re: [PATCH 2/2] arm-ccn: perf: Prevent module unload while PMU is in use
On Fri, Nov 03, 2017 at 11:45:18AM +, Suzuki K Poulose wrote: > When the PMU driver is built as a module, the perf expects the > pmu->module to be valid, so that the driver is prevented from > being unloaded while it is in use. Fix the CCN pmu driver to > fill in this field. > > Fixes: commit a33b0daab73a0 ("bus: ARM CCN PMU driver") nit: don't need "commit" here. > Cc: Pawel Moll> Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Suzuki K Poulose > --- > drivers/bus/arm-ccn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c > index e8c6946fed9d..3063f5312397 100644 > --- a/drivers/bus/arm-ccn.c > +++ b/drivers/bus/arm-ccn.c > @@ -1276,6 +1276,7 @@ static int arm_ccn_pmu_init(struct arm_ccn *ccn) > > /* Perf driver registration */ > ccn->dt.pmu = (struct pmu) { > + .module = THIS_MODULE, > .attr_groups = arm_ccn_pmu_attr_groups, > .task_ctx_nr = perf_invalid_context, > .event_init = arm_ccn_pmu_event_init, I'll pick this up since I'm taking the SPE fix via arm64 anyway. Will
Re: [PATCH 2/2] arm-ccn: perf: Prevent module unload while PMU is in use
On Fri, Nov 03, 2017 at 11:45:18AM +, Suzuki K Poulose wrote: > When the PMU driver is built as a module, the perf expects the > pmu->module to be valid, so that the driver is prevented from > being unloaded while it is in use. Fix the CCN pmu driver to > fill in this field. > > Fixes: commit a33b0daab73a0 ("bus: ARM CCN PMU driver") nit: don't need "commit" here. > Cc: Pawel Moll > Cc: Will Deacon > Cc: Mark Rutland > Signed-off-by: Suzuki K Poulose > --- > drivers/bus/arm-ccn.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c > index e8c6946fed9d..3063f5312397 100644 > --- a/drivers/bus/arm-ccn.c > +++ b/drivers/bus/arm-ccn.c > @@ -1276,6 +1276,7 @@ static int arm_ccn_pmu_init(struct arm_ccn *ccn) > > /* Perf driver registration */ > ccn->dt.pmu = (struct pmu) { > + .module = THIS_MODULE, > .attr_groups = arm_ccn_pmu_attr_groups, > .task_ctx_nr = perf_invalid_context, > .event_init = arm_ccn_pmu_event_init, I'll pick this up since I'm taking the SPE fix via arm64 anyway. Will