Re: [PATCH 2/2] clk: spear: fix WDT clock definition on SPEAr600

[Stephen Boyd]

Quoting Quentin Schulz (2018-04-06 00:50:45)
> There is no SPEAr600 device named "wdt". Instead, the description of the
> WDT (watchdog) was recently added to the Device Tree, and the device
> name is "fc88.wdt", so we should associate the WDT fixed rate clock
> to this device name.
> 
> Signed-off-by: Quentin Schulz 
> ---

Applied to clk-next

I take it there are other problems though, e.g. clcd. Why not use DT
lookups instead of clkdev ones?

Re: [PATCH 2/2] clk: spear: fix WDT clock definition on SPEAr600

[Stephen Boyd]

Quoting Quentin Schulz (2018-04-06 00:50:45)
> There is no SPEAr600 device named "wdt". Instead, the description of the
> WDT (watchdog) was recently added to the Device Tree, and the device
> name is "fc88.wdt", so we should associate the WDT fixed rate clock
> to this device name.
> 
> Signed-off-by: Quentin Schulz 
> ---

Applied to clk-next

I take it there are other problems though, e.g. clcd. Why not use DT
lookups instead of clkdev ones?

Re: [PATCH 2/2] clk: spear: fix WDT clock definition on SPEAr600

[Viresh Kumar]

On 06-04-18, 09:50, Quentin Schulz wrote:
> There is no SPEAr600 device named "wdt". Instead, the description of the
> WDT (watchdog) was recently added to the Device Tree, and the device
> name is "fc88.wdt", so we should associate the WDT fixed rate clock
> to this device name.
> 
> Signed-off-by: Quentin Schulz 
> ---
>  drivers/clk/spear/spear6xx_clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/spear/spear6xx_clock.c 
> b/drivers/clk/spear/spear6xx_clock.c
> index f911d9f..47810be 100644
> --- a/drivers/clk/spear/spear6xx_clock.c
> +++ b/drivers/clk/spear/spear6xx_clock.c
> @@ -147,7 +147,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
>  
>   clk = clk_register_fixed_factor(NULL, "wdt_clk", "osc_30m_clk", 0, 1,
>   1);
> - clk_register_clkdev(clk, NULL, "wdt");
> + clk_register_clkdev(clk, NULL, "fc88.wdt");
>  
>   /* clock derived from pll1 clk */
>   clk = clk_register_fixed_factor(NULL, "cpu_clk", "pll1_clk",

Acked-by: Viresh Kumar 

-- 
viresh

Re: [PATCH 2/2] clk: spear: fix WDT clock definition on SPEAr600

[Viresh Kumar]

On 06-04-18, 09:50, Quentin Schulz wrote:
> There is no SPEAr600 device named "wdt". Instead, the description of the
> WDT (watchdog) was recently added to the Device Tree, and the device
> name is "fc88.wdt", so we should associate the WDT fixed rate clock
> to this device name.
> 
> Signed-off-by: Quentin Schulz 
> ---
>  drivers/clk/spear/spear6xx_clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/spear/spear6xx_clock.c 
> b/drivers/clk/spear/spear6xx_clock.c
> index f911d9f..47810be 100644
> --- a/drivers/clk/spear/spear6xx_clock.c
> +++ b/drivers/clk/spear/spear6xx_clock.c
> @@ -147,7 +147,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
>  
>   clk = clk_register_fixed_factor(NULL, "wdt_clk", "osc_30m_clk", 0, 1,
>   1);
> - clk_register_clkdev(clk, NULL, "wdt");
> + clk_register_clkdev(clk, NULL, "fc88.wdt");
>  
>   /* clock derived from pll1 clk */
>   clk = clk_register_fixed_factor(NULL, "cpu_clk", "pll1_clk",

Acked-by: Viresh Kumar 

-- 
viresh