Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

> > I think it doesn't make sense to print a dev_err and return ENODEV which > > is treated by the driver core as a non-error. It means "not present, but > > OK". You probably want other error codes here. > > How about -EINVAL for these -ENODEV error codes? Do you have any suggestion? -EINVAL

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

> > I think it doesn't make sense to print a dev_err and return ENODEV which > > is treated by the driver core as a non-error. It means "not present, but > > OK". You probably want other error codes here. > > How about -EINVAL for these -ENODEV error codes? Do you have any suggestion? -EINVAL

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

Hi Wolfram, On Thu, Apr 20, 2017 at 1:05 AM, Wolfram Sang wrote: > Hi, > > have you tested these patches also without PCC? So, we can be sure there > is no regression? These patches are tested with/without PCC. > >> diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c >>

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

Hi Wolfram, On Thu, Apr 20, 2017 at 1:05 AM, Wolfram Sang wrote: > Hi, > > have you tested these patches also without PCC? So, we can be sure there > is no regression? These patches are tested with/without PCC. > >> diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c >>

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

Hi, have you tested these patches also without PCC? So, we can be sure there is no regression? > diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c > b/drivers/i2c/busses/i2c-xgene-slimpro.c > index 96545aa..a5771c1 100644 > --- a/drivers/i2c/busses/i2c-xgene-slimpro.c > +++

Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

Hi, have you tested these patches also without PCC? So, we can be sure there is no regression? > diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c > b/drivers/i2c/busses/i2c-xgene-slimpro.c > index 96545aa..a5771c1 100644 > --- a/drivers/i2c/busses/i2c-xgene-slimpro.c > +++