Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-27 Thread Paolo Bonzini
On 27/04/2018 17:19, Jim Mattson wrote: > > If the default treatment of SMIs and SMM (see Section 34.14) is > active, the VMX-preemption timer counts across an SMI to VMX non-root > operation, subsequent execution in SMM, and the return from SMM via > the RSM instruction. However, the timer can

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-27 Thread Jim Mattson
On Fri, Apr 27, 2018 at 3:03 AM, Paolo Bonzini wrote: > On 27/04/2018 00:28, Jim Mattson wrote: >> The other thing that comes to mind is that there are some new fields >> in the VMCS12 since I first implemented this. One potentially >> troublesome field is the VMX preemption

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-27 Thread Paolo Bonzini
On 27/04/2018 00:28, Jim Mattson wrote: > The other thing that comes to mind is that there are some new fields > in the VMCS12 since I first implemented this. One potentially > troublesome field is the VMX preemption timer. If the current timer > value is not saved on VM-exit, then it won't be

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-26 Thread Jim Mattson
I'll send out a patch to deal with nested_run_pending. The other thing that comes to mind is that there are some new fields in the VMCS12 since I first implemented this. One potentially troublesome field is the VMX preemption timer. If the current timer value is not saved on VM-exit, then it

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-16 Thread Raslan, KarimAllah
On Mon, 2018-04-16 at 09:22 -0700, Jim Mattson wrote: > On Thu, Apr 12, 2018 at 8:12 AM, KarimAllah Ahmed wrote: > > > > > v2 -> v3: > > - Remove the forced VMExit from L2 after reading the kvm_state. The actual > > problem is solved. > > - Rebase again! > > - Set

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-16 Thread Jim Mattson
On Thu, Apr 12, 2018 at 8:12 AM, KarimAllah Ahmed wrote: > v2 -> v3: > - Remove the forced VMExit from L2 after reading the kvm_state. The actual > problem is solved. > - Rebase again! > - Set nested_run_pending during restore (not sure if it makes sense yet or > not).

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-14 Thread Raslan, KarimAllah
On Sat, 2018-04-14 at 15:56 +, Raslan, KarimAllah wrote: > On Thu, 2018-04-12 at 17:12 +0200, KarimAllah Ahmed wrote: > > > > From: Jim Mattson > > > > For nested virtualization L0 KVM is managing a bit of state for L2 guests, > > this state can not be captured through

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-14 Thread Raslan, KarimAllah
On Thu, 2018-04-12 at 17:12 +0200, KarimAllah Ahmed wrote: > From: Jim Mattson > > For nested virtualization L0 KVM is managing a bit of state for L2 guests, > this state can not be captured through the currently available IOCTLs. In > fact the state captured through all of

Re: [PATCH 2/2] kvm: nVMX: Introduce KVM_CAP_STATE

2018-04-12 Thread Paolo Bonzini
On 12/04/2018 17:12, KarimAllah Ahmed wrote: > From: Jim Mattson > > For nested virtualization L0 KVM is managing a bit of state for L2 guests, > this state can not be captured through the currently available IOCTLs. In > fact the state captured through all of these IOCTLs