Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-17 Thread Christoph Hellwig
On Wed, Jul 11, 2018 at 04:52:10PM +0300, Serge Semin wrote: > Hello Christoph, > > On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig > wrote: > > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > > > + * requests a cachable mapping with CWB attribute enabled. > >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-17 Thread Christoph Hellwig
On Wed, Jul 11, 2018 at 04:52:10PM +0300, Serge Semin wrote: > Hello Christoph, > > On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig > wrote: > > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > > > + * requests a cachable mapping with CWB attribute enabled. > >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Serge Semin
Hello Christoph, On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig wrote: > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > > + * requests a cachable mapping with CWB attribute enabled. > > */ > > #define ioremap_cacheable_cow(offset, size)

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Serge Semin
Hello Christoph, On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig wrote: > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > > + * requests a cachable mapping with CWB attribute enabled. > > */ > > #define ioremap_cacheable_cow(offset, size)

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Serge Semin
Paul, On Tue, Jul 10, 2018 at 02:04:15PM -0700, Paul Burton wrote: > Hi Serge, > > On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote: > > On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton > > wrote: > > > However FYI for next time - you shouldn't really add someone else's > > >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Serge Semin
Paul, On Tue, Jul 10, 2018 at 02:04:15PM -0700, Paul Burton wrote: > Hi Serge, > > On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote: > > On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton > > wrote: > > > However FYI for next time - you shouldn't really add someone else's > > >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Christoph Hellwig
> + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > + * requests a cachable mapping with CWB attribute enabled. > */ > #define ioremap_cacheable_cow(offset, size) \ > __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW) This isn't actually

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-11 Thread Christoph Hellwig
> + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > + * requests a cachable mapping with CWB attribute enabled. > */ > #define ioremap_cacheable_cow(offset, size) \ > __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW) This isn't actually

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Paul Burton
Hi Serge, On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote: > On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton > wrote: > > However FYI for next time - you shouldn't really add someone else's > > Signed-off-by tag anyway. The tag effectively states that a person can > > agree to

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Paul Burton
Hi Serge, On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote: > On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton > wrote: > > However FYI for next time - you shouldn't really add someone else's > > Signed-off-by tag anyway. The tag effectively states that a person can > > agree to

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Serge Semin
On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton wrote: Hello Paul, > Hi Sergey, > > On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote: > > On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre > > wrote: > > > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin > > > wrote: >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Serge Semin
On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton wrote: Hello Paul, > Hi Sergey, > > On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote: > > On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre > > wrote: > > > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin > > > wrote: >

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Paul Burton
Hi Sergey, On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote: > On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre > wrote: > > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > > Adaptive ioremap_wc() method is now available (see "mips: mm: > > > Create UCA-based

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Paul Burton
Hi Sergey, On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote: > On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre > wrote: > > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > > Adaptive ioremap_wc() method is now available (see "mips: mm: > > > Create UCA-based

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Serge Semin
On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre wrote: > ' > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > > > Adaptive ioremap_wc() method is now available (see "mips: mm: > > Create UCA-based ioremap_wc() method" commit). We can use it for > > UCA-featured MMIO

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Serge Semin
On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre wrote: > ' > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > > > Adaptive ioremap_wc() method is now available (see "mips: mm: > > Create UCA-based ioremap_wc() method" commit). We can use it for > > UCA-featured MMIO

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Mathieu Malaterre
' On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > Adaptive ioremap_wc() method is now available (see "mips: mm: > Create UCA-based ioremap_wc() method" commit). We can use it for > UCA-featured MMIO transactions in the kernel, so we don't need > it platform clone

Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method

2018-07-10 Thread Mathieu Malaterre
' On Mon, Jul 9, 2018 at 3:57 PM Serge Semin wrote: > > Adaptive ioremap_wc() method is now available (see "mips: mm: > Create UCA-based ioremap_wc() method" commit). We can use it for > UCA-featured MMIO transactions in the kernel, so we don't need > it platform clone