Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-27 Thread matthew . gerlach
Hi Cyrille, I think I figured out the confusion with regards to dummy cycles. See my comment in line. Matthew Gerlach On Tue, 15 Aug 2017, Cyrille Pitchen wrote: Le 15/08/2017 à 19:20, matthew.gerl...@linux.intel.com a écrit : Hi Cyrille, Thanks for the great feedback. See my

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-27 Thread matthew . gerlach
Hi Cyrille, I think I figured out the confusion with regards to dummy cycles. See my comment in line. Matthew Gerlach On Tue, 15 Aug 2017, Cyrille Pitchen wrote: Le 15/08/2017 à 19:20, matthew.gerl...@linux.intel.com a écrit : Hi Cyrille, Thanks for the great feedback. See my

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-15 Thread Cyrille Pitchen
Le 15/08/2017 à 19:20, matthew.gerl...@linux.intel.com a écrit : > > Hi Cyrille, > > Thanks for the great feedback. See my comments inline. > > Matthew Gerlach > > On Fri, 11 Aug 2017, Cyrille Pitchen wrote: > >> Hi Matthew, >> >> Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-15 Thread Cyrille Pitchen
Le 15/08/2017 à 19:20, matthew.gerl...@linux.intel.com a écrit : > > Hi Cyrille, > > Thanks for the great feedback. See my comments inline. > > Matthew Gerlach > > On Fri, 11 Aug 2017, Cyrille Pitchen wrote: > >> Hi Matthew, >> >> Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-15 Thread matthew . gerlach
Hi Cyrille, Thanks for the great feedback. See my comments inline. Matthew Gerlach On Fri, 11 Aug 2017, Cyrille Pitchen wrote: Hi Matthew, Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a écrit : From: Matthew Gerlach Signed-off-by: Matthew

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-15 Thread matthew . gerlach
Hi Cyrille, Thanks for the great feedback. See my comments inline. Matthew Gerlach On Fri, 11 Aug 2017, Cyrille Pitchen wrote: Hi Matthew, Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a écrit : From: Matthew Gerlach Signed-off-by: Matthew Gerlach --- MAINTAINERS

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-11 Thread Cyrille Pitchen
Hi Matthew, Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a écrit : > From: Matthew Gerlach > > Signed-off-by: Matthew Gerlach > --- > MAINTAINERS | 7 + > drivers/mtd/spi-nor/Kconfig

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-11 Thread Cyrille Pitchen
Hi Matthew, Le 06/08/2017 à 20:24, matthew.gerl...@linux.intel.com a écrit : > From: Matthew Gerlach > > Signed-off-by: Matthew Gerlach > --- > MAINTAINERS | 7 + > drivers/mtd/spi-nor/Kconfig | 6 + > drivers/mtd/spi-nor/Makefile| 3 +- >

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-07 Thread matthew . gerlach
On Sun, 6 Aug 2017, Marek Vasut wrote: Hi Marek, Thanks for the feedback. Please see comments inline. Matthew Gerlach On 08/06/2017 08:24 PM, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach Thanks for the descriptive commit message. Could

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-07 Thread matthew . gerlach
On Sun, 6 Aug 2017, Marek Vasut wrote: Hi Marek, Thanks for the feedback. Please see comments inline. Matthew Gerlach On 08/06/2017 08:24 PM, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach Thanks for the descriptive commit message. Could you explain what this patch is

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core (fwd)

2017-08-07 Thread Julia Lawall
dev_err does not seem possible to use here (line 447). julia -- Forwarded message -- Date: Mon, 7 Aug 2017 04:45:58 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 2/2] mtd: spi-nor:

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core (fwd)

2017-08-07 Thread Julia Lawall
dev_err does not seem possible to use here (line 447). julia -- Forwarded message -- Date: Mon, 7 Aug 2017 04:45:58 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core Hi Matthew, [auto build

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-06 Thread Marek Vasut
On 08/06/2017 08:24 PM, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach Thanks for the descriptive commit message. Could you explain what this patch is all about ? > Signed-off-by: Matthew Gerlach [...] > diff

Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

2017-08-06 Thread Marek Vasut
On 08/06/2017 08:24 PM, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach Thanks for the descriptive commit message. Could you explain what this patch is all about ? > Signed-off-by: Matthew Gerlach [...] > diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile