Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-22 Thread Philipp Zabel
Hi Geert, On Thu, 2018-02-22 at 09:50 +0100, Geert Uytterhoeven wrote: [...] > > > @@ -127,8 +134,15 @@ static int vfio_platform_get_reset(struct > > > vfio_platform_device *vdev) > > > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > > >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-22 Thread Geert Uytterhoeven
Hi Philipp, On Wed, Feb 21, 2018 at 5:51 PM, Philipp Zabel wrote: > I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see > below: > > On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: >> Vfio-platform requires reset support, provided either

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-21 Thread Philipp Zabel
Hi Geert, I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see below: On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-21 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 11:11 AM, Auger Eric wrote: > On 14/02/18 10:43, Geert Uytterhoeven wrote: >> On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: >>> On 13/02/18 17:36, Geert Uytterhoeven wrote: Vfio-platform requires reset

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Auger Eric
Hi Geert, On 14/02/18 10:43, Geert Uytterhoeven wrote: > Hi Eric, > > On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: >> On 13/02/18 17:36, Geert Uytterhoeven wrote: >>> Vfio-platform requires reset support, provided either by ACPI, or, on DT >>> platforms, by a

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: > On 13/02/18 17:36, Geert Uytterhoeven wrote: >> Vfio-platform requires reset support, provided either by ACPI, or, on DT >> platforms, by a device-specific reset driver matching against the >> device's

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Auger Eric
Hi Geert, On 13/02/18 17:36, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the > device's compatible value. > > On many SoCs, devices are connected to an SoC-internal reset