Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Thomas Gleixner]

On Fri, 9 Feb 2018, Jia Zhang wrote:
> 
> Anybody else here who can give an attention on this review?

Jiri gave you perfectly valid feedback. Please address that and repost a V2.

Thanks,

tglx

Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Thomas Gleixner]

On Fri, 9 Feb 2018, Jia Zhang wrote:
> 
> Anybody else here who can give an attention on this review?

Jiri gave you perfectly valid feedback. Please address that and repost a V2.

Thanks,

tglx

Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Jia Zhang]

Hi,

Anybody else here who can give an attention on this review?

Thanks,
Jia

On 2018/2/5 下午5:26, Jiri Olsa wrote:
> On Tue, Jan 30, 2018 at 02:42:59PM +0800, Jia Zhang wrote:
>> The vsyscall page should be visible only if
>> vsyscall=emulate/native when dumping /proc/kcore.
>>
>> Signed-off-by: Jia Zhang 
>> ---
>>  arch/x86/mm/init_64.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index dab78f6..3d4cf33 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1186,8 +1186,9 @@ void __init mem_init(void)
>>  register_page_bootmem_info();
>>  
>>  /* Register memory areas for /proc/kcore */
>> -kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
>> -   PAGE_SIZE, KCORE_USER);
>> +if (get_gate_vma(_mm))
>> +kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
>> +   PAGE_SIZE, KCORE_USER);
> 
> nit, we use { } when there's more than 1 line code 
> 
> anyway the approach looks ok to me
> 
> Reviewed-by: Jiri Olsa 
> 
> thanks,
> jirka
> 

Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Jia Zhang]

Hi,

Anybody else here who can give an attention on this review?

Thanks,
Jia

On 2018/2/5 下午5:26, Jiri Olsa wrote:
> On Tue, Jan 30, 2018 at 02:42:59PM +0800, Jia Zhang wrote:
>> The vsyscall page should be visible only if
>> vsyscall=emulate/native when dumping /proc/kcore.
>>
>> Signed-off-by: Jia Zhang 
>> ---
>>  arch/x86/mm/init_64.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index dab78f6..3d4cf33 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1186,8 +1186,9 @@ void __init mem_init(void)
>>  register_page_bootmem_info();
>>  
>>  /* Register memory areas for /proc/kcore */
>> -kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
>> -   PAGE_SIZE, KCORE_USER);
>> +if (get_gate_vma(_mm))
>> +kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
>> +   PAGE_SIZE, KCORE_USER);
> 
> nit, we use { } when there's more than 1 line code 
> 
> anyway the approach looks ok to me
> 
> Reviewed-by: Jiri Olsa 
> 
> thanks,
> jirka
> 

Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Jiri Olsa]

On Tue, Jan 30, 2018 at 02:42:59PM +0800, Jia Zhang wrote:
> The vsyscall page should be visible only if
> vsyscall=emulate/native when dumping /proc/kcore.
> 
> Signed-off-by: Jia Zhang 
> ---
>  arch/x86/mm/init_64.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index dab78f6..3d4cf33 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -1186,8 +1186,9 @@ void __init mem_init(void)
>   register_page_bootmem_info();
>  
>   /* Register memory areas for /proc/kcore */
> - kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
> -PAGE_SIZE, KCORE_USER);
> + if (get_gate_vma(_mm))
> + kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
> +PAGE_SIZE, KCORE_USER);

nit, we use { } when there's more than 1 line code 

anyway the approach looks ok to me

Reviewed-by: Jiri Olsa 

thanks,
jirka

Re: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally

[Jiri Olsa]

On Tue, Jan 30, 2018 at 02:42:59PM +0800, Jia Zhang wrote:
> The vsyscall page should be visible only if
> vsyscall=emulate/native when dumping /proc/kcore.
> 
> Signed-off-by: Jia Zhang 
> ---
>  arch/x86/mm/init_64.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index dab78f6..3d4cf33 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -1186,8 +1186,9 @@ void __init mem_init(void)
>   register_page_bootmem_info();
>  
>   /* Register memory areas for /proc/kcore */
> - kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
> -PAGE_SIZE, KCORE_USER);
> + if (get_gate_vma(_mm))
> + kclist_add(_vsyscall, (void *)VSYSCALL_ADDR,
> +PAGE_SIZE, KCORE_USER);

nit, we use { } when there's more than 1 line code 

anyway the approach looks ok to me

Reviewed-by: Jiri Olsa 

thanks,
jirka