Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Kani, Toshi
On Wed, 2018-03-14 at 20:56 +0100, Thomas Gleixner wrote: > On Wed, 14 Mar 2018, Kani, Toshi wrote: > > On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > > > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > > > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > > >

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Kani, Toshi
On Wed, 2018-03-14 at 20:56 +0100, Thomas Gleixner wrote: > On Wed, 14 Mar 2018, Kani, Toshi wrote: > > On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > > > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > > > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > > >

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Thomas Gleixner
On Wed, 14 Mar 2018, Kani, Toshi wrote: > On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > > Once it's set, all tables underneath are identical. There is no point >

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Thomas Gleixner
On Wed, 14 Mar 2018, Kani, Toshi wrote: > On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > > Once it's set, all tables underneath are identical. There is no point >

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Kani, Toshi
On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > Once it's set, all tables underneath are identical. There is no point > > of following the same page table with two

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Kani, Toshi
On Wed, 2018-03-14 at 20:27 +0100, Thomas Gleixner wrote: > On Tue, 13 Mar 2018, Toshi Kani wrote: > > > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > > Once it's set, all tables underneath are identical. There is no point > > of following the same page table with two

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Thomas Gleixner
On Tue, 13 Mar 2018, Toshi Kani wrote: > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > Once it's set, all tables underneath are identical. There is no point > of following the same page table with two separate pointers and makes > sure they see the same with BUG(). > >

Re: [PATCH 2/2] x86/mm: remove pointless checks in vmalloc_fault

2018-03-14 Thread Thomas Gleixner
On Tue, 13 Mar 2018, Toshi Kani wrote: > vmalloc_fault() sets user's pgd or p4d from the kernel page table. > Once it's set, all tables underneath are identical. There is no point > of following the same page table with two separate pointers and makes > sure they see the same with BUG(). > >