Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value

[Taniya Das]

Hello Stephen,

Thanks for the review comments.

On 4/6/2018 4:54 AM, Stephen Boyd wrote:

Quoting Taniya Das (2018-04-02 03:45:44)

From: Amit Nischal 

For some gdscs, it might take longer time up to 500us for
updating their status. So add support for the same by
defining a new flag 'GDS_TIMEOUT' to mark such gdsc in
order to poll their status for longer timeout value.

Signed-off-by: Amit Nischal 
Signed-off-by: Taniya Das 
---


Let's just increase the timeout to 500 if it's required? This is a
timeout, so we're not really expecting to hit it anyway so optimizing
the uncommon case is not useful.
--


Will fix this in the next series.


To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value

[Taniya Das]

Hello Stephen,

Thanks for the review comments.

On 4/6/2018 4:54 AM, Stephen Boyd wrote:

Quoting Taniya Das (2018-04-02 03:45:44)

From: Amit Nischal 

For some gdscs, it might take longer time up to 500us for
updating their status. So add support for the same by
defining a new flag 'GDS_TIMEOUT' to mark such gdsc in
order to poll their status for longer timeout value.

Signed-off-by: Amit Nischal 
Signed-off-by: Taniya Das 
---


Let's just increase the timeout to 500 if it's required? This is a
timeout, so we're not really expecting to hit it anyway so optimizing
the uncommon case is not useful.
--


Will fix this in the next series.


To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value

[Stephen Boyd]

Quoting Taniya Das (2018-04-02 03:45:44)
> From: Amit Nischal 
> 
> For some gdscs, it might take longer time up to 500us for
> updating their status. So add support for the same by
> defining a new flag 'GDS_TIMEOUT' to mark such gdsc in
> order to poll their status for longer timeout value.
> 
> Signed-off-by: Amit Nischal 
> Signed-off-by: Taniya Das 
> ---

Let's just increase the timeout to 500 if it's required? This is a
timeout, so we're not really expecting to hit it anyway so optimizing
the uncommon case is not useful.

Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value

[Stephen Boyd]

Quoting Taniya Das (2018-04-02 03:45:44)
> From: Amit Nischal 
> 
> For some gdscs, it might take longer time up to 500us for
> updating their status. So add support for the same by
> defining a new flag 'GDS_TIMEOUT' to mark such gdsc in
> order to poll their status for longer timeout value.
> 
> Signed-off-by: Amit Nischal 
> Signed-off-by: Taniya Das 
> ---

Let's just increase the timeout to 500 if it's required? This is a
timeout, so we're not really expecting to hit it anyway so optimizing
the uncommon case is not useful.