Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

2018-12-16 Thread Masahiro Yamada
On Sat, Dec 15, 2018 at 3:34 AM Nick Desaulniers wrote: > > On Fri, Dec 14, 2018 at 12:06 AM Masahiro Yamada > wrote: > > > > -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden > > -Wstrict-prototypes (plural) > > > by -Werror=strict-prototype later. > >

Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

2018-12-14 Thread Nick Desaulniers
On Fri, Dec 14, 2018 at 12:06 AM Masahiro Yamada wrote: > > -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden -Wstrict-prototypes (plural) > by -Werror=strict-prototype later. -Werror=strict-prototypes (plural) LGTM: https://godbolt.org/z/DyEpmU If you would mind updating