Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Tue, Nov 15, 2016 at 03:23:36PM +0900, Namhyung Kim wrote: > On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > > On Sat, Aug 20,

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Tue, Nov 15, 2016 at 03:23:36PM +0900, Namhyung Kim wrote: > On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > > On Sat, Aug 20,

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > > > + > > > > +/* the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > > > + > > > > +/* the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > > Add virtio pstore device to allow kernel log files saved on the host. > > > It will save the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > > Add virtio pstore device to allow kernel log files saved on the host. > > > It will save the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Thu, Sep 22, 2016 at 01:23:16PM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 04, 2016 at 11:38:59PM +0900, Namhyung Kim wrote: > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > +{ > > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > > +VirtQueueElement *elem; > > +

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Thu, Sep 22, 2016 at 01:23:16PM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 04, 2016 at 11:38:59PM +0900, Namhyung Kim wrote: > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > +{ > > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > > +VirtQueueElement *elem; > > +

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Sun, Sep 04, 2016 at 11:38:59PM +0900, Namhyung Kim wrote: > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > +{ > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > +VirtQueueElement *elem; > +struct virtio_pstore_req req; > +struct virtio_pstore_res res; > +

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Sun, Sep 04, 2016 at 11:38:59PM +0900, Namhyung Kim wrote: > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > +{ > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > +VirtQueueElement *elem; > +struct virtio_pstore_req req; > +struct virtio_pstore_res res; > +

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by pstore device > > option. > > > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by pstore device > > option. > > > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Aug 26, 2016 at 01:48:40PM +0900, Namhyung Kim wrote: > Hi Daniel, > > On Wed, Aug 24, 2016 at 06:00:51PM -0400, Daniel P. Berrange wrote: > > > +fd = open(filename, O_RDONLY); > > > +if (fd < 0) { > > > +error_report("cannot open %s", filename); > > > +goto out;

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Fri, Aug 26, 2016 at 01:48:40PM +0900, Namhyung Kim wrote: > Hi Daniel, > > On Wed, Aug 24, 2016 at 06:00:51PM -0400, Daniel P. Berrange wrote: > > > +fd = open(filename, O_RDONLY); > > > +if (fd < 0) { > > > +error_report("cannot open %s", filename); > > > +goto out;

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hi Daniel, On Wed, Aug 24, 2016 at 06:00:51PM -0400, Daniel P. Berrange wrote: > > > diff --git a/hw/virtio/virtio-pstore.c b/hw/virtio/virtio-pstore.c > > new file mode 100644 > > index 000..b8fb4be > > --- /dev/null > > +++ b/hw/virtio/virtio-pstore.c > > @@ -0,0 +1,699 @@ > > +/* > > + *

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hi Daniel, On Wed, Aug 24, 2016 at 06:00:51PM -0400, Daniel P. Berrange wrote: > > > diff --git a/hw/virtio/virtio-pstore.c b/hw/virtio/virtio-pstore.c > > new file mode 100644 > > index 000..b8fb4be > > --- /dev/null > > +++ b/hw/virtio/virtio-pstore.c > > @@ -0,0 +1,699 @@ > > +/* > > + *

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

> diff --git a/hw/virtio/virtio-pstore.c b/hw/virtio/virtio-pstore.c > new file mode 100644 > index 000..b8fb4be > --- /dev/null > +++ b/hw/virtio/virtio-pstore.c > @@ -0,0 +1,699 @@ > +/* > + * Virtio Pstore Device > + * > + * Copyright (C) 2016 LG Electronics > + * > + * Authors: > + *

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

> diff --git a/hw/virtio/virtio-pstore.c b/hw/virtio/virtio-pstore.c > new file mode 100644 > index 000..b8fb4be > --- /dev/null > +++ b/hw/virtio/virtio-pstore.c > @@ -0,0 +1,699 @@ > +/* > + * Virtio Pstore Device > + * > + * Copyright (C) 2016 LG Electronics > + * > + * Authors: > + *

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 09:29:06AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 11:21:18PM +0900, Namhyung Kim wrote: > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > > From: Namhyung Kim

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 09:29:06AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 11:21:18PM +0900, Namhyung Kim wrote: > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > > From: Namhyung Kim > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 09:21:08AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 20, 2016 at 12:48:39AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > > +static

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 09:21:08AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 20, 2016 at 12:48:39AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > > +static

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Mon, Jul 18, 2016 at 11:21:18PM +0900, Namhyung Kim wrote: > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > From: Namhyung Kim > > > > > > Add virtio pstore device to allow kernel log

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Mon, Jul 18, 2016 at 11:21:18PM +0900, Namhyung Kim wrote: > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > From: Namhyung Kim > > > > > > Add virtio pstore device to allow kernel log files saved on the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 12:48:39AM +0900, Namhyung Kim wrote: > Hello, > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > > +{ > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Wed, Jul 20, 2016 at 12:48:39AM +0900, Namhyung Kim wrote: > Hello, > > On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > > +{ > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > +{ > > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > > +VirtQueueElement

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > +static void virtio_pstore_handle_io(VirtIODevice *vdev, VirtQueue *vq) > > +{ > > +VirtIOPstore *s = VIRTIO_PSTORE(vdev); > > +VirtQueueElement

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > From: Namhyung Kim > > > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 11:03:53AM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > > From: Namhyung Kim > > > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 09:28:42AM +0200, Christian Borntraeger wrote: > On 07/18/2016 06:37 AM, Namhyung Kim wrote: > > Can you do the virtio-mmio and virtio-ccw plumbing as well, or > do you need help with that? Any help would be greatly appreciated! Thanks, Namhyung > > [...] > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

Hello, On Mon, Jul 18, 2016 at 09:28:42AM +0200, Christian Borntraeger wrote: > On 07/18/2016 06:37 AM, Namhyung Kim wrote: > > Can you do the virtio-mmio and virtio-ccw plumbing as well, or > do you need help with that? Any help would be greatly appreciated! Thanks, Namhyung > > [...] > >

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On 07/18/2016 06:37 AM, Namhyung Kim wrote: Can you do the virtio-mmio and virtio-ccw plumbing as well, or do you need help with that? [...] > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 2b34b43..8281b80 100644 > --- a/hw/virtio/virtio-pci.c > +++

Re: [PATCH 2/3] qemu: Implement virtio-pstore device

On 07/18/2016 06:37 AM, Namhyung Kim wrote: Can you do the virtio-mmio and virtio-ccw plumbing as well, or do you need help with that? [...] > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 2b34b43..8281b80 100644 > --- a/hw/virtio/virtio-pci.c > +++