Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Stefan Lippers-Hollmann
Hi On 2016-07-22, Arnd Bergmann wrote: > On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > > Stefan Lippers-Hollmann writes: > > > On 2016-07-20, Arnd Bergmann wrote: > > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > > >> > Arnd Bergmann

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Stefan Lippers-Hollmann
Hi On 2016-07-22, Arnd Bergmann wrote: > On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > > Stefan Lippers-Hollmann writes: > > > On 2016-07-20, Arnd Bergmann wrote: > > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > > >> > Arnd Bergmann writes: >

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Arnd Bergmann
On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > Stefan Lippers-Hollmann writes: > > Hi > > > > On 2016-07-20, Arnd Bergmann wrote: > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > >> > Arnd Bergmann writes: > >> > > On

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Arnd Bergmann
On Friday, July 22, 2016 7:55:36 AM CEST Jes Sorensen wrote: > Stefan Lippers-Hollmann writes: > > Hi > > > > On 2016-07-20, Arnd Bergmann wrote: > >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > >> > Arnd Bergmann writes: > >> > > On Wednesday, July 20, 2016 7:25:19 AM

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Jes Sorensen
Stefan Lippers-Hollmann writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann writes: >> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> > >> Arnd

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-22 Thread Jes Sorensen
Stefan Lippers-Hollmann writes: > Hi > > On 2016-07-20, Arnd Bergmann wrote: >> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: >> > Arnd Bergmann writes: >> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> > >> Arnd Bergmann writes: > [...] >> Yes, I

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-21 Thread Stefan Lippers-Hollmann
Hi On 2016-07-20, Arnd Bergmann wrote: > On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > > Arnd Bergmann writes: > > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > > >> Arnd Bergmann writes: [...] > Yes, I was just

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-21 Thread Stefan Lippers-Hollmann
Hi On 2016-07-20, Arnd Bergmann wrote: > On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > > Arnd Bergmann writes: > > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > > >> Arnd Bergmann writes: [...] > Yes, I was just agreeing here that it's not worth

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > >> Arnd Bergmann writes: > >> Well it really all depends on how much time I have and how much others > >>

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > >> Arnd Bergmann writes: > >> Well it really all depends on how much time I have and how much others > >> step up and help contribute to

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Christian Lamparter
On Wednesday, July 20, 2016 5:06:27 PM CEST Xose Vazquez Perez wrote: > Arnd Bergmann wrote: > > > rtlwifi, but I found the older r8712u device to work fine with > > the staging/rtl8712 driver. > > A replacement for "staging/rtl8712", with MAC80211 support, is > available at:

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Christian Lamparter
On Wednesday, July 20, 2016 5:06:27 PM CEST Xose Vazquez Perez wrote: > Arnd Bergmann wrote: > > > rtlwifi, but I found the older r8712u device to work fine with > > the staging/rtl8712 driver. > > A replacement for "staging/rtl8712", with MAC80211 support, is > available at:

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute to the code. For rtl8xxxu my plans are as >>

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> Well it really all depends on how much time I have and how much others >> step up and help contribute to the code. For rtl8xxxu my plans are as >> follows: >> >> 1) rtl8188eu

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > >> I'd like to get rid of all the drivers/staging/rtl* drivers eventually > > > > That would be great, yes. > > > > Can you clarify what the long-term plan is? I see that > >

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > >> I'd like to get rid of all the drivers/staging/rtl* drivers eventually > > > > That would be great, yes. > > > > Can you clarify what the long-term plan is? I see that > >

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Xose Vazquez Perez
Arnd Bergmann wrote: > rtlwifi, but I found the older r8712u device to work fine with > the staging/rtl8712 driver. A replacement for "staging/rtl8712", with MAC80211 support, is available at: https://github.com/chunkeey/rtl8192su Also a fullmac/cfg80211 driver(r92su) is

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Xose Vazquez Perez
Arnd Bergmann wrote: > rtlwifi, but I found the older r8712u device to work fine with > the staging/rtl8712 driver. A replacement for "staging/rtl8712", with MAC80211 support, is available at: https://github.com/chunkeey/rtl8192su Also a fullmac/cfg80211 driver(r92su) is available at the same

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Larry Finger
On 07/20/2016 06:25 AM, Jes Sorensen wrote: Arnd Bergmann writes: On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: Arnd Bergmann writes: I think that would be better, albeit not a big issue. Ok, and since Kalle applied the first patch to his

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Larry Finger
On 07/20/2016 06:25 AM, Jes Sorensen wrote: Arnd Bergmann writes: On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: Arnd Bergmann writes: I think that would be better, albeit not a big issue. Ok, and since Kalle applied the first patch to his tree, I'm now sending a series of

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> I think that would be better, albeit not a big issue. > > Ok, and since Kalle applied the first patch to his tree, I'm now sending > a series of three

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Jes Sorensen
Arnd Bergmann writes: > On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: >> Arnd Bergmann writes: >> I think that would be better, albeit not a big issue. > > Ok, and since Kalle applied the first patch to his tree, I'm now sending > a series of three patches that are all for

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: > >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c > >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c > >> > index

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-20 Thread Arnd Bergmann
On Tuesday, July 19, 2016 12:05:00 PM CEST Jes Sorensen wrote: > Arnd Bergmann writes: > > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: > >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c > >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c > >> > index

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644 >> > ---

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644 >> > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c >>

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Arnd Bergmann
On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: > > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > b/drivers/staging/rtl8192e/rtl819x_TSProc.c > > index 2c8a526773ed..e0a2fe5e6148 100644 > > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > +++

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Arnd Bergmann
On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: > > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > b/drivers/staging/rtl8192e/rtl819x_TSProc.c > > index 2c8a526773ed..e0a2fe5e6148 100644 > > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > +++

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of data type