On Tue, Jan 20, 2015 at 09:13:12AM -0800, Guenter Roeck wrote:
> On Tue, Jan 20, 2015 at 10:44:01AM -0500, Vivien Didelot wrote:
> > Hi Guenter,
> >
> [ ... ]
> >
> > > Anyway, my goal was to keep things simple. Taking some bits from the
> > > default
> > > and others from the return value of
On Tue, Jan 20, 2015 at 10:44:01AM -0500, Vivien Didelot wrote:
> Hi Guenter,
>
[ ... ]
>
> > Anyway, my goal was to keep things simple. Taking some bits from the default
> > and others from the return value of the is_visible function isn't simple,
> > even more so since your code would require
Hi Guenter,
>>> @@ -55,6 +55,12 @@ static int create_files(struct kernfs_node *parent,
>>> struct kobject *kobj,
>>> if (!mode)
>>> continue;
>>> }
>>> +
>>> +WARN(mode &
Hi Guenter,
@@ -55,6 +55,12 @@ static int create_files(struct kernfs_node *parent,
struct kobject *kobj,
if (!mode)
continue;
}
+
+WARN(mode ~(S_IRUGO | S_IWUGO |
On Tue, Jan 20, 2015 at 10:44:01AM -0500, Vivien Didelot wrote:
Hi Guenter,
[ ... ]
Anyway, my goal was to keep things simple. Taking some bits from the default
and others from the return value of the is_visible function isn't simple,
even more so since your code would require the
On Tue, Jan 20, 2015 at 09:13:12AM -0800, Guenter Roeck wrote:
On Tue, Jan 20, 2015 at 10:44:01AM -0500, Vivien Didelot wrote:
Hi Guenter,
[ ... ]
Anyway, my goal was to keep things simple. Taking some bits from the
default
and others from the return value of the is_visible
On 01/19/2015 04:07 PM, Vivien Didelot wrote:
Hi Guenter,
For sysfs file attributes, only read and write permisssions make sense.
Minor typo, there's an extra 's' to permissions.
Mask provided attribute permissions accordingly and send a warning
to the console if invalid permission bits
Hi Guenter,
> For sysfs file attributes, only read and write permisssions make sense.
Minor typo, there's an extra 's' to permissions.
> Mask provided attribute permissions accordingly and send a warning
> to the console if invalid permission bits are set.
>
> Cc: Vivien Didelot
>
Hi Guenter,
For sysfs file attributes, only read and write permisssions make sense.
Minor typo, there's an extra 's' to permissions.
Mask provided attribute permissions accordingly and send a warning
to the console if invalid permission bits are set.
Cc: Vivien Didelot
On 01/19/2015 04:07 PM, Vivien Didelot wrote:
Hi Guenter,
For sysfs file attributes, only read and write permisssions make sense.
Minor typo, there's an extra 's' to permissions.
Mask provided attribute permissions accordingly and send a warning
to the console if invalid permission bits
10 matches
Mail list logo
