Re: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-22 Thread Bryan Wu
On Wed, Aug 22, 2012 at 1:46 PM, Kim, Milo wrote: >> Hmmm, I think we still should use cancel_work() here based on your >> idea. Please find the patch from Tejun and add him to this loop >> [PATCH 4/6] workqueue: deprecate flush[_delayed]_work_sync() >> --- >> Before this patchset, >> >>

Re: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-22 Thread Bryan Wu
On Wed, Aug 22, 2012 at 1:46 PM, Kim, Milo milo@ti.com wrote: Hmmm, I think we still should use cancel_work() here based on your idea. Please find the patch from Tejun and add him to this loop [PATCH 4/6] workqueue: deprecate flush[_delayed]_work_sync() --- Before this patchset,

RE: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-21 Thread Kim, Milo
> Hmmm, I think we still should use cancel_work() here based on your > idea. Please find the patch from Tejun and add him to this loop > [PATCH 4/6] workqueue: deprecate flush[_delayed]_work_sync() > --- > Before this patchset, > > flush_work() > > flush the last queued instance of the

Re: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-21 Thread Bryan Wu
On Tue, Aug 21, 2012 at 5:03 PM, Kim, Milo wrote: > Turning off the brightness of each channel is required > when removing the driver. > > So use flush_work_sync() rather than cancel_work_sync() to wait for > unhandled brightness works. Hmmm, I think we still should use cancel_work() here based

Re: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-21 Thread Bryan Wu
On Tue, Aug 21, 2012 at 5:03 PM, Kim, Milo milo@ti.com wrote: Turning off the brightness of each channel is required when removing the driver. So use flush_work_sync() rather than cancel_work_sync() to wait for unhandled brightness works. Hmmm, I think we still should use cancel_work()

RE: [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver

2012-08-21 Thread Kim, Milo
Hmmm, I think we still should use cancel_work() here based on your idea. Please find the patch from Tejun and add him to this loop [PATCH 4/6] workqueue: deprecate flush[_delayed]_work_sync() --- Before this patchset, flush_work() flush the last queued instance of the work