Re: [PATCH 2/4] staging: most: Replace calls to BUG_ON() with WARN_ONCE() and return.

2018-03-06 Thread Dan Carpenter
On Tue, Mar 06, 2018 at 01:23:18AM -0800, Quytelda Kahja wrote: > > Are you sure this will work? > Well, my goal was just to replace the code that could crash the kernel > and let somebody with a better understanding of this particular driver > write the recovery code, if necessary. It seemed from

Re: [PATCH 2/4] staging: most: Replace calls to BUG_ON() with WARN_ONCE() and return.

2018-03-06 Thread Quytelda Kahja
> Are you sure this will work? Well, my goal was just to replace the code that could crash the kernel and let somebody with a better understanding of this particular driver write the recovery code, if necessary. It seemed from context that the BUG_ON() calls were being used like assert() though, s

Re: [PATCH 2/4] staging: most: Replace calls to BUG_ON() with WARN_ONCE() and return.

2018-03-01 Thread Greg KH
On Fri, Feb 23, 2018 at 11:58:33PM -0800, Quytelda Kahja wrote: > Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE() > followed by a return. Are you sure this will work? > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/most/core.c | 13 ++--- > 1 file c