Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Sun, Sep 18, 2016 at 03:47:43PM +0200, Frederic Weisbecker wrote: > I love that! I've seen so many cases where I wanted this runtime check without > the overhead of it on production kernels. > > I can take that patch, now since this is lockdep code and my series is > scheduler's > code that

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Sun, Sep 18, 2016 at 03:47:43PM +0200, Frederic Weisbecker wrote: > I love that! I've seen so many cases where I wanted this runtime check without > the overhead of it on production kernels. > > I can take that patch, now since this is lockdep code and my series is > scheduler's > code that

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Wed, Sep 07, 2016 at 09:59:13AM +0200, Peter Zijlstra wrote: > On Fri, Sep 02, 2016 at 04:03:02PM +0200, Frederic Weisbecker wrote: > > > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > > index f111076..d4d12a9 100644 > > --- a/kernel/sched/cputime.c > > +++

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Wed, Sep 07, 2016 at 09:59:13AM +0200, Peter Zijlstra wrote: > On Fri, Sep 02, 2016 at 04:03:02PM +0200, Frederic Weisbecker wrote: > > > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > > index f111076..d4d12a9 100644 > > --- a/kernel/sched/cputime.c > > +++

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, Sep 02, 2016 at 04:03:02PM +0200, Frederic Weisbecker wrote: > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > index f111076..d4d12a9 100644 > --- a/kernel/sched/cputime.c > +++ b/kernel/sched/cputime.c > @@ -78,30 +78,26 @@ EXPORT_SYMBOL_GPL(irqtime_account_irq); > static

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, Sep 02, 2016 at 04:03:02PM +0200, Frederic Weisbecker wrote: > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > index f111076..d4d12a9 100644 > --- a/kernel/sched/cputime.c > +++ b/kernel/sched/cputime.c > @@ -78,30 +78,26 @@ EXPORT_SYMBOL_GPL(irqtime_account_irq); > static

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, 2016-09-02 at 16:03 +0200, Frederic Weisbecker wrote: > The callers of the functions performing irqtime kcpustat updates have > IRQS disabled, no need to disable them again. > > Cc: Rik van Riel > Cc: Paolo Bonzini > Cc: Wanpeng Li

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, 2016-09-02 at 16:03 +0200, Frederic Weisbecker wrote: > The callers of the functions performing irqtime kcpustat updates have > IRQS disabled, no need to disable them again. > > Cc: Rik van Riel > Cc: Paolo Bonzini > Cc: Wanpeng Li > Cc: Mike Galbraith > Cc: Peter Zijlstra > Cc: Ingo

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, Sep 02, 2016 at 04:53:47PM +0200, Paolo Bonzini wrote: > > > On 02/09/2016 16:03, Frederic Weisbecker wrote: > > The callers of the functions performing irqtime kcpustat updates have > > IRQS disabled, no need to disable them again. > > They do, but perhaps this should be annotated

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On Fri, Sep 02, 2016 at 04:53:47PM +0200, Paolo Bonzini wrote: > > > On 02/09/2016 16:03, Frederic Weisbecker wrote: > > The callers of the functions performing irqtime kcpustat updates have > > IRQS disabled, no need to disable them again. > > They do, but perhaps this should be annotated

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On 02/09/2016 16:03, Frederic Weisbecker wrote: > The callers of the functions performing irqtime kcpustat updates have > IRQS disabled, no need to disable them again. They do, but perhaps this should be annotated through some sparse magic. It's starting to be hairy, with the requirement

Re: [PATCH 2/5] irqtime: Remove needless IRQs disablement on kcpustat update

On 02/09/2016 16:03, Frederic Weisbecker wrote: > The callers of the functions performing irqtime kcpustat updates have > IRQS disabled, no need to disable them again. They do, but perhaps this should be annotated through some sparse magic. It's starting to be hairy, with the requirement