Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-22 Thread Amelie DELAUNAY
On 02/22/2018 02:44 PM, Linus Walleij wrote: > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay > wrote: > > Thanks for working on this complex expander driver. > It is a bit daunting. Sorry if there are lots of comments and > considerations, but it reflects the

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-22 Thread Amelie DELAUNAY
On 02/22/2018 02:44 PM, Linus Walleij wrote: > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay > wrote: > > Thanks for working on this complex expander driver. > It is a bit daunting. Sorry if there are lots of comments and > considerations, but it reflects the complexity of the hardware. >

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-22 Thread Linus Walleij
On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay wrote: Thanks for working on this complex expander driver. It is a bit daunting. Sorry if there are lots of comments and considerations, but it reflects the complexity of the hardware. > +enum mfx_block { > +

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-22 Thread Linus Walleij
On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay wrote: Thanks for working on this complex expander driver. It is a bit daunting. Sorry if there are lots of comments and considerations, but it reflects the complexity of the hardware. > +enum mfx_block { > + MFX_BLOCK_GPIO =

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-19 Thread Amelie DELAUNAY
On 02/12/2018 01:06 PM, Lee Jones wrote: > On Thu, 08 Feb 2018, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) is a slave controller using I2C >> for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually configurable in input/output >> - 8 alternate

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-19 Thread Amelie DELAUNAY
On 02/12/2018 01:06 PM, Lee Jones wrote: > On Thu, 08 Feb 2018, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) is a slave controller using I2C >> for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually configurable in input/output >> - 8 alternate

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-19 Thread Amelie DELAUNAY
Thanks Philippe, I will take this into account for V2. Regards, Amelie On 02/12/2018 03:15 PM, Philippe Ombredanne wrote: > Amelie, > > On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones wrote: >> On Thu, 08 Feb 2018, Amelie Delaunay wrote: >> >>> ST Multi-Function eXpander

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-19 Thread Amelie DELAUNAY
Thanks Philippe, I will take this into account for V2. Regards, Amelie On 02/12/2018 03:15 PM, Philippe Ombredanne wrote: > Amelie, > > On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones wrote: >> On Thu, 08 Feb 2018, Amelie Delaunay wrote: >> >>> ST Multi-Function eXpander (MFX) is a slave

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-12 Thread Philippe Ombredanne
Amelie, On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones wrote: > On Thu, 08 Feb 2018, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) is a slave controller using I2C >> for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-12 Thread Philippe Ombredanne
Amelie, On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones wrote: > On Thu, 08 Feb 2018, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) is a slave controller using I2C >> for communication with the main MCU. Main features are: >> - 16 fast GPIOs individually configurable in input/output >>

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-12 Thread Lee Jones
On Thu, 08 Feb 2018, Amelie Delaunay wrote: > ST Multi-Function eXpander (MFX) is a slave controller using I2C > for communication with the main MCU. Main features are: > - 16 fast GPIOs individually configurable in input/output > - 8 alternate GPIOs individually configurable in input/output > -

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

2018-02-12 Thread Lee Jones
On Thu, 08 Feb 2018, Amelie Delaunay wrote: > ST Multi-Function eXpander (MFX) is a slave controller using I2C > for communication with the main MCU. Main features are: > - 16 fast GPIOs individually configurable in input/output > - 8 alternate GPIOs individually configurable in input/output > -