Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

On Tue, Jul 24, 2018 at 1:05 PM Eric W. Biederman wrote: > > What I hear you asking is moving up copy_signal copy_sighand copy_creds > and alloc_pid, and anything else that signal delivery might depend on. No, _just_ signal allocation. It would still just use the special-case list to set the

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

On Tue, Jul 24, 2018 at 1:05 PM Eric W. Biederman wrote: > > What I hear you asking is moving up copy_signal copy_sighand copy_creds > and alloc_pid, and anything else that signal delivery might depend on. No, _just_ signal allocation. It would still just use the special-case list to set the

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

Linus Torvalds writes: > On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman > wrote: >> >> Yes you are quite right. Easy enough to fix, but it definitely needs >> to be fixed. >> >> I will respin. > > Would you mind trying a slightly different approach for this? > > How about moving the

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

Linus Torvalds writes: > On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman > wrote: >> >> Yes you are quite right. Easy enough to fix, but it definitely needs >> to be fixed. >> >> I will respin. > > Would you mind trying a slightly different approach for this? > > How about moving the

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman wrote: > > Yes you are quite right. Easy enough to fix, but it definitely needs > to be fixed. > > I will respin. Would you mind trying a slightly different approach for this? How about moving the "copy_signal()" and "copy_sighandler()" cases

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

On Tue, Jul 24, 2018 at 10:58 AM Eric W. Biederman wrote: > > Yes you are quite right. Easy enough to fix, but it definitely needs > to be fixed. > > I will respin. Would you mind trying a slightly different approach for this? How about moving the "copy_signal()" and "copy_sighandler()" cases

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

Linus Torvalds writes: > This is completely broken. > > On Mon, Jul 23, 2018 at 8:27 PM Eric W. Biederman > wrote: >> >> diff --git a/kernel/fork.c b/kernel/fork.c >> index 6c358846a8b8..6ee5822f0085 100644 >> --- a/kernel/fork.c >> +++ b/kernel/fork.c >> @@ -1602,6 +1603,24 @@ static

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

Linus Torvalds writes: > This is completely broken. > > On Mon, Jul 23, 2018 at 8:27 PM Eric W. Biederman > wrote: >> >> diff --git a/kernel/fork.c b/kernel/fork.c >> index 6c358846a8b8..6ee5822f0085 100644 >> --- a/kernel/fork.c >> +++ b/kernel/fork.c >> @@ -1602,6 +1603,24 @@ static

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

This is completely broken. On Mon, Jul 23, 2018 at 8:27 PM Eric W. Biederman wrote: > > diff --git a/kernel/fork.c b/kernel/fork.c > index 6c358846a8b8..6ee5822f0085 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1602,6 +1603,24 @@ static __latent_entropy struct task_struct >

Re: [PATCH 20/20] signal: Don't restart fork when signals come in.

This is completely broken. On Mon, Jul 23, 2018 at 8:27 PM Eric W. Biederman wrote: > > diff --git a/kernel/fork.c b/kernel/fork.c > index 6c358846a8b8..6ee5822f0085 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1602,6 +1603,24 @@ static __latent_entropy struct task_struct >