Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-19 Thread Andrea Arcangeli
On Fri, Jan 19, 2018 at 04:15:33AM +, Van De Ven, Arjan wrote: > there is no such guarantee. Some of the IBRS implementations will > actually flush rather than disable, or flush parts and disable other > parts. To me it helps in order to memorize the spec to understand why the spec is the way

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-19 Thread Andrea Arcangeli
On Fri, Jan 19, 2018 at 04:15:33AM +, Van De Ven, Arjan wrote: > there is no such guarantee. Some of the IBRS implementations will > actually flush rather than disable, or flush parts and disable other > parts. To me it helps in order to memorize the spec to understand why the spec is the way

RE: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Van De Ven, Arjan
> Enabling IBRS does not prevent software from controlling the predicted > targets of indirect branches of unrelated software executed later at > the same predictor mode (for example, between two different user > applications, or two different virtual machines). Such isolation can > be ensured

RE: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Van De Ven, Arjan
> Enabling IBRS does not prevent software from controlling the predicted > targets of indirect branches of unrelated software executed later at > the same predictor mode (for example, between two different user > applications, or two different virtual machines). Such isolation can > be ensured

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andy Lutomirski
On Thu, Jan 18, 2018 at 5:41 PM, Andrea Arcangeli wrote: > Hello, > > On Thu, Jan 18, 2018 at 03:25:25PM -0800, Andy Lutomirski wrote: >> I read the whitepaper that documented the new MSRs a couple days ago >> and I'm now completely unable to find it. If anyone could send

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andy Lutomirski
On Thu, Jan 18, 2018 at 5:41 PM, Andrea Arcangeli wrote: > Hello, > > On Thu, Jan 18, 2018 at 03:25:25PM -0800, Andy Lutomirski wrote: >> I read the whitepaper that documented the new MSRs a couple days ago >> and I'm now completely unable to find it. If anyone could send the >> link, that would

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
Hello, On Thu, Jan 18, 2018 at 03:25:25PM -0800, Andy Lutomirski wrote: > I read the whitepaper that documented the new MSRs a couple days ago > and I'm now completely unable to find it. If anyone could send the > link, that would be great. I see Andrew posted a link. > From memory, however,

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
Hello, On Thu, Jan 18, 2018 at 03:25:25PM -0800, Andy Lutomirski wrote: > I read the whitepaper that documented the new MSRs a couple days ago > and I'm now completely unable to find it. If anyone could send the > link, that would be great. I see Andrew posted a link. > From memory, however,

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrew Cooper
On 18/01/2018 23:25, Andy Lutomirski wrote: > On Thu, Jan 18, 2018 at 11:08 AM, Andrea Arcangeli > wrote: >> On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: >>> On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: On 18/01/2018 18:08, Dave

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrew Cooper
On 18/01/2018 23:25, Andy Lutomirski wrote: > On Thu, Jan 18, 2018 at 11:08 AM, Andrea Arcangeli > wrote: >> On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: >>> On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: On 18/01/2018 18:08, Dave Hansen wrote: > On

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andy Lutomirski
On Thu, Jan 18, 2018 at 11:08 AM, Andrea Arcangeli wrote: > On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: >> On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: >> > On 18/01/2018 18:08, Dave Hansen wrote: >> > > On 01/18/2018 08:37 AM, Josh

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andy Lutomirski
On Thu, Jan 18, 2018 at 11:08 AM, Andrea Arcangeli wrote: > On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: >> On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: >> > On 18/01/2018 18:08, Dave Hansen wrote: >> > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: >> > >>>

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > > On 18/01/2018 18:08, Dave Hansen wrote: > > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > > >>> > > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Andrea Arcangeli
On Thu, Jan 18, 2018 at 12:24:31PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > > On 18/01/2018 18:08, Dave Hansen wrote: > > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > > >>> > > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > On 18/01/2018 18:08, Dave Hansen wrote: > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > >>> > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >>> +++ b/Documentation/admin-guide/kernel-parameters.txt > >>> @@ -3932,6

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 06:12:36PM +0100, Paolo Bonzini wrote: > On 18/01/2018 18:08, Dave Hansen wrote: > > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: > >>> > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >>> +++ b/Documentation/admin-guide/kernel-parameters.txt > >>> @@ -3932,6

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 18:08, Dave Hansen wrote: > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: >>> >>> --- a/Documentation/admin-guide/kernel-parameters.txt >>> +++ b/Documentation/admin-guide/kernel-parameters.txt >>> @@ -3932,6 +3932,7 @@ >>> retpoline - replace indirect

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 18:08, Dave Hansen wrote: > On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: >>> >>> --- a/Documentation/admin-guide/kernel-parameters.txt >>> +++ b/Documentation/admin-guide/kernel-parameters.txt >>> @@ -3932,6 +3932,7 @@ >>> retpoline - replace indirect

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Dave Hansen
On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: >> >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -3932,6 +3932,7 @@ >> retpoline - replace indirect branches >>

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Dave Hansen
On 01/18/2018 08:37 AM, Josh Poimboeuf wrote: >> >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -3932,6 +3932,7 @@ >> retpoline - replace indirect branches >>

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 02:48:23PM +0100, Peter Zijlstra wrote: > From: Thomas Gleixner > > Add the minimal infrastructure to control the speculation control feature. > > - Integrate it into the spectre_v2 coammand line parser and the mitigation >selector function. The

Re: [PATCH 23/35] x86/speculation: Add basic speculation control code

2018-01-18 Thread Josh Poimboeuf
On Thu, Jan 18, 2018 at 02:48:23PM +0100, Peter Zijlstra wrote: > From: Thomas Gleixner > > Add the minimal infrastructure to control the speculation control feature. > > - Integrate it into the spectre_v2 coammand line parser and the mitigation >selector function. The conditional selector